Modify

Opened 6 years ago

Closed 5 years ago

Last modified 4 years ago

#9913 closed defect (fixed)

xmail package for AR71xx platform build with wrong endiannes

Reported by: Paco93@… Owned by: nico
Priority: normal Milestone: Chaos Calmer 15.05
Component: packages Version: Backfire 10.03.1 RC5
Keywords: xmail 1.26 Cc:

Description

A sysmachine.pach has undefs (MACH_BIG_ENDIAN_WORDS and MACH_BIG_ENDIAN_BITFIELDS) setting little endiannes.
We should instead define both MACH_BIG_ENDIAN_WORDS and MACH_BIG_ENDIAN_BITFIELDS)

Attachments (1)

xmail-fix_endianness_detection.patch (903 bytes) - added by НКВД 6 years ago.
Patch to fix the endianness detection issues of xmail package

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by НКВД

This patch fixes the endianness detection issues of the xmail package.

Index: feeds/packages/mail/xmail/patches/030-sysmachine.patch
===================================================================
--- feeds/packages/mail/xmail/patches/030-sysmachine.patch	(revisión: 28138)
+++ feeds/packages/mail/xmail/patches/030-sysmachine.patch	(copia de trabajo)
@@ -1,14 +1,20 @@
 diff -urN xmail-1.25.orig/SysMachine.h xmail-1.25/SysMachine.h
 --- xmail-1.25.orig/SysMachine.h	1970-01-01 01:00:00.000000000 +0100
 +++ xmail-1.25/SysMachine.h	2008-07-28 10:16:47.000000000 +0200
-@@ -0,0 +1,24 @@
+@@ -0,0 +1,30 @@
 +#ifndef _MACHDEFS_H
 +#define _MACHDEFS_H
 +
 +
++#include <endian.h>
++
++#if __BYTE_ORDER == __LITTLE_ENDIAN
 +#undef MACH_BIG_ENDIAN_WORDS
-+
 +#undef MACH_BIG_ENDIAN_BITFIELD
++#elif __BYTE_ORDER == __BIG_ENDIAN
++#define MACH_BIG_ENDIAN_WORDS
++#define MACH_BIG_ENDIAN_BITFIELD
++#endif
 +
 +typedef signed char MachInt8;
 +typedef unsigned char MachUInt8;

Changed 6 years ago by НКВД

Patch to fix the endianness detection issues of xmail package

comment:2 Changed 6 years ago by nico

  • Owner changed from developers to nico
  • Status changed from new to accepted

comment:3 Changed 6 years ago by caog

Again just a comment to verify I see the same problem and am in the process of checking the proposed fix.

comment:4 follow-ups: Changed 6 years ago by caog

Fix works for me on ar71xx tl-wr703n.

comment:5 in reply to: ↑ 4 Changed 6 years ago by anonymous

Replying to caog:

Fix works for me on ar71xx tl-wr703n.

Thanks for the code
Executive assistant job description

comment:6 in reply to: ↑ 4 Changed 5 years ago by trandus@…

Replying to caog:

Fix works for me on ar71xx tl-wr703n.

Hi. Could you share the patched XMail ipk package or binaries? I would be very grateful :)
It is very hard to me apply the patch and compile package because actualy I don't know how to do it.
I also couldn't find this package on Internet.

comment:7 Changed 5 years ago by nico

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed in [36236], thanks.

comment:8 Changed 4 years ago by jow

  • Milestone changed from Backfire 10.03.2 to Chaos Calmer (trunk)

Milestone Backfire 10.03.2 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.