Modify

Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#9542 closed defect (fixed)

[PATCH] vnstat patch removal broke Darwin / BSD builds

Reported by: dirtyfreebooter <openwrt-devel@…> Owned by: developers
Priority: high Milestone: Barrier Breaker 14.07
Component: packages Version: Trunk
Keywords: vnstat, darwin, bsd, freebsd, install, portability Cc:

Description

Change set r27116 removed the 004-install_bsd_fix.patch patch. This patch is still needed. The author fixed the "BSD" install target in the makefile, but since we are cross-compiling for linux, the linux install target is the one that is actually executed. (i.e. the linux target is run on BSD host using the host's install binary) This breaks the OpenWRT build on Darwin and BSD hosts. I expressed to the author that he should just drop "-D" from both targets and be 100% portable, even for cross-compiling, but I guess he decided to only fix it for the BSD target. Attached is a refreshed patch for the latest 1.11 package. Thanks

Installing vnStat...
Installing config to /Volumes/OpenWrt/DIR825/trunk/build_dir/target-mips_r2_uClibc-0.9.32/vnstat-1.11/ipkg-install/etc/vnstat.conf
install: illegal option -- D
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 file2
       install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 ... fileN directory
       install -d [-v] [-g group] [-m mode] [-o owner] directory ...
make[4]: *** [install] Error 64
make[3]: *** [/Volumes/OpenWrt/DIR825/trunk/build_dir/target-mips_r2_uClibc-0.9.32/vnstat-1.11/.built] Error 2
make[3]: Leaving directory `/Volumes/OpenWrt/DIR825/trunk/feeds/packages/net/vnstat'
make[2]: *** [package/feeds/packages/vnstat/compile] Error 2
make[2]: *** Waiting for unfinished jobs....

Attachments (1)

004-install_bsd_fix.patch (673 bytes) - added by Joe Roback <openwrt-devel@…> 7 years ago.
BSD install fix patch

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by Joe Roback <openwrt-devel@…>

BSD install fix patch

comment:1 Changed 7 years ago by swalker

  • Resolution set to fixed
  • Status changed from new to closed

Sigh, fixed in r27154, thanks Joe.

comment:2 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.