HDLC line discipline support broken with new linux source code

[richard.spiers@…]

Hi

The HDLC kernel module no longer compiles successfully with the latest revision (pulled 01/06/2011).

This is because there was a commit in the linux source code moving the relevant files (n_hdlc.c etc) to a different directory (from drivers/char/ to drivers/tty/).

See the commit at ​http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.37.y.git;a=commit;h=96fd7ce58ffb5c7bf376796b5525ba3ea1c9d69f

This results in

cp: cannot stat `/home/richard/metarouter/trunk/build_dir/linux-ar71xx_nand/linux-2.6.37.6/drivers/char/n_hdlc.ko': No such file or directory

during the build process.

Unfortunately setting an older kernel version (i.e. 2.6.36.4 does not work as the rest of the ar71xx patches do not apply cleanly to an older version)

Can somebody give some advice on where we can make the changes for these files ? I would imagine not too big a patch is needed, just some file locations that need to be updated ?

Thanks

Kind Regards
Richard Spiers

P.S. Sorry about the lack of exact revisions and error messages, I've moved through several different revisions trying to find a working match.

[anonymous]

I forgot to mention that I enabled the compilation of the module by the following change taken from ​http://blog.rtg.in.ua/2009/04/openwrt-l2tp-client.html

Index: package/kernel/modules/other.mk
===================================================================
--- package/kernel/modules/other.mk (revision 15274)
+++ package/kernel/modules/other.mk (working copy)
@@ -822,3 +822,18 @@

$(eval $(call KernelPackage,rfkill))

+define KernelPackage/hdlc
+ SUBMENU:=$(OTHER_MENU)
+ TITLE:=HDLC line discipline support
+ KCONFIG:= \
+ CONFIG_N_HDLC=m \
+ CONFIG_SERIAL_NONSTANDARD=y
+ FILES:=$(LINUX_DIR)/drivers/char/n_hdlc.$(LINUX_KMOD_SUFFIX)
+ AUTOLOAD:=$(call AutoLoad,20,hdlc)
+endef
+
+define KernelPackage/hdlc/description
+ Kernel module for HDLC line discipline support
+endef
+
+$(eval $(call KernelPackage,hdlc))

[jow]

So just replace "/char/" with "/tty/" in your patch? I don't see any hdlc module in trunk, therefore I'm not sure what this ticket is supposed to be for...

[anonymous]

Hi

Yes my apologies

I just realised the same thing...

Thanks