Modify

Opened 7 years ago

Closed 6 years ago

#9179 closed defect (fixed)

Openl2tp is not in package list in backfire

Reported by: Dmitry Tunin <hanipouspilot@…> Owned by: developers
Priority: normal Milestone: Backfire 10.03.1
Component: packages Version: Trunk
Keywords: Cc:

Description

There is a bug in Makefile thats prevent openl2tp from compiling. Wrobg dependency.

The fix patch is in 9155 with upgrade to 1.8
Please add it before releasing RC5 to be able to install from repository.

Attachments (0)

Change History (16)

comment:1 Changed 7 years ago by Dmitry Tunin <hanipouspilot@…>

This may be closed. Patch added.

comment:2 Changed 7 years ago by hauke

  • Resolution set to fixed
  • Status changed from new to closed

This bug should be fixed in r26549.

comment:3 follow-up: Changed 7 years ago by Dmitry Tunin <hanipouspilot@…>

  • Resolution fixed deleted
  • Status changed from closed to reopened

It seems that patch for 1.8 was added in a wrong way to svn. The package does not compile to snapshots or backfire. I applied the same НКВД patch and for me it works.
Please, try to add the patch in a right way.

comment:4 Changed 7 years ago by Dmitry Tunin <hanipouspilot@…>

comment:5 in reply to: ↑ 3 Changed 7 years ago by jow

Replying to Dmitry Tunin <hanipouspilot@…>:

It seems that patch for 1.8 was added in a wrong way to svn. The package does not compile to snapshots or backfire. I applied the same НКВД patch and for me it works.
Please, try to add the patch in a right way.

The patch was applied correctly but openl2tpd depends on "rpcgen" features not found on all systems:

make[2]: Entering directory `/home/buildslave/openwrt1/ar71xx/build/feeds/packages/net/openl2tp'
. /home/buildslave/openwrt1/ar71xx/build/include/shell.sh; . /home/buildslave/openwrt1/ar71xx/build/include/shell.sh; gzip -dc /home/buildslave/openwrt1/ar71xx/build/dl/openl2tp-1.8.tar.gz | /bin/tar -C /home/buildslave/openwrt1/ar71xx/build/build_dir/linux-ar71xx_generic/openl2tp-1.8/.. -xf - 

Applying ./patches/001-makefile.patch using plaintext: 
patching file Makefile

Applying ./patches/010-ppp_unix.patch using plaintext: 
patching file plugins/ppp_unix.c
touch /home/buildslave/openwrt1/ar71xx/build/build_dir/linux-ar71xx_generic/openl2tp-1.8/.prepared_9b30ed6721e029dc82a63921c3a16552
(cd /home/buildslave/openwrt1/ar71xx/build/build_dir/linux-ar71xx_generic/openl2tp-1.8/./; if [ -x ./configure ]; then /usr/bin/find /home/buildslave/openwrt1/ar71xx/build/build_dir/linux-ar71xx_generic/openl2tp-1.8/ -name config.guess | xargs -r chmod u+w; /usr/bin/find /home/buildslave/openwrt1/ar71xx/build/build_dir/linux-ar71xx_generic/openl2tp-1.8/ -name config.guess | xargs -r -n1 cp /home/buildslave/openwrt1/ar71xx/build/scripts/config.guess; /usr/bin/find /home/buildslave/openwrt1/ar71xx/build/build_dir/linux-ar71xx_generic/openl2tp-1.8/ -name config.sub | xargs -r chmod u+w; /usr/bin/find /home/buildslave/openwrt1/ar71xx/build/build_dir/linux-ar71xx_generic/openl2tp-1.8/ -name config.sub | xargs -r -n1 cp /home/buildslave/openwrt1/ar71xx/build/scripts/config.sub; AR=mips-openwrt-linux-uclibc-ar AS="mips-openwrt-linux-uclibc-gcc -c -Os -pipe -mips32r2 -mtune=mips32r2 -fno-caller-saves -fhonour-copts -msoft-float" LD=mips-openwrt-linux-uclibc-ld NM=mips-openwrt-linux-uclibc-nm CC="mips-openwrt-linux-uclibc-gcc" GCC="mips-openwrt-linux-uclibc-gcc" CXX="mips-openwrt-linux-uclibc-g++" RANLIB=mips-openwrt-linux-uclibc-ranlib STRIP=mips-openwrt-linux-uclibc-strip OBJCOPY=mips-openwrt-linux-uclibc-objcopy OBJDUMP=mips-openwrt-linux-uclibc-objdump SIZE=mips-openwrt-linux-uclibc-size CFLAGS="-Os -pipe -mips32r2 -mtune=mips32r2 -fno-caller-saves -fhonour-copts -msoft-float " CXXFLAGS="-Os -pipe -mips32r2 -mtune=mips32r2 -fno-caller-saves -fhonour-copts -msoft-float " CPPFLAGS="-I/home/buildslave/openwrt1/ar71xx/build/staging_dir/target-mips_r2_uClibc-0.9.32/usr/include -I/home/buildslave/openwrt1/ar71xx/build/staging_dir/target-mips_r2_uClibc-0.9.32/include -I/home/buildslave/openwrt1/ar71xx/build/staging_dir/toolchain-mips_r2_gcc-linaro_uClibc-0.9.32/usr/include -I/home/buildslave/openwrt1/ar71xx/build/staging_dir/toolchain-mips_r2_gcc-linaro_uClibc-0.9.32/include " LDFLAGS="-L/home/buildslave/openwrt1/ar71xx/build/staging_dir/target-mips_r2_uClibc-0.9.32/usr/lib -L/home/buildslave/openwrt1/ar71xx/build/staging_dir/target-mips_r2_uClibc-0.9.32/lib -L/home/buildslave/openwrt1/ar71xx/build/staging_dir/toolchain-mips_r2_gcc-linaro_uClibc-0.9.32/usr/lib -L/home/buildslave/openwrt1/ar71xx/build/staging_dir/toolchain-mips_r2_gcc-linaro_uClibc-0.9.32/lib "   ./configure --target=mips-openwrt-linux --host=mips-openwrt-linux --build=x86_64-linux-gnu --program-prefix="" --program-suffix="" --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --libexecdir=/usr/lib --sysconfdir=/etc --datadir=/usr/share --localstatedir=/var --mandir=/usr/man --infodir=/usr/info --disable-nls   ; fi; )
touch /home/buildslave/openwrt1/ar71xx/build/build_dir/linux-ar71xx_generic/openl2tp-1.8/.configured_
CFLAGS="-Os -pipe -mips32r2 -mtune=mips32r2 -fno-caller-saves -fhonour-copts -msoft-float  -I/home/buildslave/openwrt1/ar71xx/build/staging_dir/target-mips_r2_uClibc-0.9.32/usr/include -I/home/buildslave/openwrt1/ar71xx/build/staging_dir/target-mips_r2_uClibc-0.9.32/include -I/home/buildslave/openwrt1/ar71xx/build/staging_dir/toolchain-mips_r2_gcc-linaro_uClibc-0.9.32/usr/include -I/home/buildslave/openwrt1/ar71xx/build/staging_dir/toolchain-mips_r2_gcc-linaro_uClibc-0.9.32/include " CXXFLAGS="-Os -pipe -mips32r2 -mtune=mips32r2 -fno-caller-saves -fhonour-copts -msoft-float  -I/home/buildslave/openwrt1/ar71xx/build/staging_dir/target-mips_r2_uClibc-0.9.32/usr/include -I/home/buildslave/openwrt1/ar71xx/build/staging_dir/target-mips_r2_uClibc-0.9.32/include -I/home/buildslave/openwrt1/ar71xx/build/staging_dir/toolchain-mips_r2_gcc-linaro_uClibc-0.9.32/usr/include -I/home/buildslave/openwrt1/ar71xx/build/staging_dir/toolchain-mips_r2_gcc-linaro_uClibc-0.9.32/include " LDFLAGS="-L/home/buildslave/openwrt1/ar71xx/build/staging_dir/target-mips_r2_uClibc-0.9.32/usr/lib -L/home/buildslave/openwrt1/ar71xx/build/staging_dir/target-mips_r2_uClibc-0.9.32/lib -L/home/buildslave/openwrt1/ar71xx/build/staging_dir/toolchain-mips_r2_gcc-linaro_uClibc-0.9.32/usr/lib -L/home/buildslave/openwrt1/ar71xx/build/staging_dir/toolchain-mips_r2_gcc-linaro_uClibc-0.9.32/lib " make  -j1 -C /home/buildslave/openwrt1/ar71xx/build/build_dir/linux-ar71xx_generic/openl2tp-1.8/. AR=mips-openwrt-linux-uclibc-ar AS="mips-openwrt-linux-uclibc-gcc -c -Os -pipe -mips32r2 -mtune=mips32r2 -fno-caller-saves -fhonour-copts -msoft-float" LD=mips-openwrt-linux-uclibc-ld NM=mips-openwrt-linux-uclibc-nm CC="mips-openwrt-linux-uclibc-gcc" GCC="mips-openwrt-linux-uclibc-gcc" CXX="mips-openwrt-linux-uclibc-g++" RANLIB=mips-openwrt-linux-uclibc-ranlib STRIP=mips-openwrt-linux-uclibc-strip OBJCOPY=mips-openwrt-linux-uclibc-objcopy OBJDUMP=mips-openwrt-linux-uclibc-objdump SIZE=mips-openwrt-linux-uclibc-size CROSS="mips-openwrt-linux-uclibc-" ARCH="mips" KERNEL_SRCDIR="/home/buildslave/openwrt1/ar71xx/build/build_dir/linux-ar71xx_generic/linux-2.6.37.6" KERNEL_BLDDIR="/home/buildslave/openwrt1/ar71xx/build/build_dir/linux-ar71xx_generic/linux-2.6.37.6" PPPD_VERSION="" READLINE_DIR="/home/buildslave/openwrt1/ar71xx/build/staging_dir/target-mips_r2_uClibc-0.9.32/usr" PPPD_SRCDIR="/home/buildslave/openwrt1/ar71xx/build/staging_dir/target-mips_r2_uClibc-0.9.32/usr/include" PPPD_LIBDIR="/home/buildslave/openwrt1/ar71xx/build/staging_dir/target-mips_r2_uClibc-0.9.32/usr/lib" CPPFLAGS="-I/home/buildslave/openwrt1/ar71xx/build/staging_dir/target-mips_r2_uClibc-0.9.32/usr/include" LIBS.dmalloc="-L/home/buildslave/openwrt1/ar71xx/build/staging_dir/target-mips_r2_uClibc-0.9.32/usr/lib -lrpc" ;
make[3]: Entering directory `/home/buildslave/openwrt1/ar71xx/build/build_dir/linux-ar71xx_generic/openl2tp-1.8'
rm -f l2tp_rpc.h
rpcgen -N -M -C -L -h -o l2tp_rpc.h l2tp_rpc.x
usage:  rpcgen infile
	rpcgen [-a][-b][-C][-Dname[=value]] -i size  [-I [-K seconds]] [-L][-N][-T] infile
	rpcgen [-c | -h | -l | -m | -t | -Sc | -Ss] [-o outfile] [infile]
	rpcgen [-s nettype]* [-o outfile] [infile]
	rpcgen [-n netid]* [-o outfile] [infile]
options:
-a		generate all files, including samples
-b		backward compatibility mode (generates code for SunOS 4.1)
-c		generate XDR routines
-C		ANSI C mode
-Dname[=value]	define a symbol (same as #define)
-h		generate header file
-i size		size at which to start generating inline code
-I		generate code for inetd support in server (for SunOS 4.1)
-K seconds	server exits after K seconds of inactivity
-l		generate client side stubs
-L		server errors will be printed to syslog
-m		generate server side stubs
-n netid	generate server code that supports named netid
-N		supports multiple arguments and call-by-value
-o outfile	name of the output file
-s nettype	generate server code that supports named nettype
-Sc		generate sample client code that uses remote procedures
-Ss		generate sample server code that defines remote procedures
-t		generate RPC dispatch table
-T		generate code to support RPC dispatch tables
-Y path		directory name to find C preprocessor (cpp)
make[3]: *** [l2tp_rpc.h] Error 1
make[3]: Leaving directory `/home/buildslave/openwrt1/ar71xx/build/build_dir/linux-ar71xx_generic/openl2tp-1.8'
make[2]: *** [/home/buildslave/openwrt1/ar71xx/build/build_dir/linux-ar71xx_generic/openl2tp-1.8/.built] Error 2
make[2]: Leaving directory `/home/buildslave/openwrt1/ar71xx/build/feeds/packages/net/openl2tp'

Your patch did not involve rpcgen at all so I don't see how it was applied incorrectly.

comment:6 follow-up: Changed 7 years ago by Dmitry Tunin <hanipouspilot@…>

Rpc is portmap package. For me openl2tp compiles and works. I just added the patch using git. It applied and all works. No errors at all.

comment:7 in reply to: ↑ 6 Changed 7 years ago by Dmitry Tunin <hanipouspilot@…>

Maybe it is some problem of the compilation system. But before openl2tp 1.7 compiled OK, until you made recursive dependency (+kmod-pppol2tp +ppp) in r25860.

comment:8 Changed 7 years ago by Dmitry Tunin <hanipouspilot@…>

May be that $(LIBRPC_DEPENDS) is also the cause.

comment:9 Changed 7 years ago by jow

This is pointless speculation, fact is that the host system of the buildbot does not support "-M" in its "rpcgen" command. SO yes, it works for you, it also works for me but it does not work on the buildbot. This has nothing to do with depends or wrongly applied patches.

comment:10 Changed 7 years ago by Dmitry Tunin <hanipouspilot@…>

Got you. And what is the solution to bet build bot compile the package?
Regarding depends, it is true that openl2tp stopped compiling since that change in Makefile. I fixed it by changing order of depends, and after that was made a patch for 1.8

comment:11 Changed 7 years ago by anonymous

is there any specific reason why portmap/rpc dependency is enabled in openl2tp? I use it without portmap on my system (debian), as it reduces the size of the openl2tp binaries and memory usage.

See here on how to disable the RPC dependency: https://forum.openwrt.org/viewtopic.php?pid=130260#p130260

comment:12 Changed 7 years ago by Pilot6 <hanipouspilot@…>

Portmap is used as an RPC. You are right that it is possible to build without RPC.

comment:13 Changed 7 years ago by Pilot6 <hanipouspilot@…>

But when using withiout RPC some features won't be available, e.g. address of L2TP server by domain name, etc.

comment:14 Changed 7 years ago by anonymous

Can you elaborate that? as far as I know, all features that l2tpconfig allows you to change can be set through the /etc/openl2tpd.conf too. I think you can reload the config file without restarting openl2tp too by sending the right signal

comment:15 Changed 7 years ago by Pilot6 <hanipouspilot@…>

Not all features can be set in config file. May be in next versions they will fix it. There is no reason to limit it in Openwrt. Who wants to gain 1k memory can build himself without RPC.

comment:16 Changed 6 years ago by nico

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in r28429 & r28758

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.