Modify

Opened 7 years ago

Last modified 4 years ago

#8967 assigned defect

dropbear inetd mode regression from openwrt package 0.52 -> 0.53

Reported by: ddxx0n Owned by: kaloz
Priority: low Milestone: Barrier Breaker 14.07
Component: packages Version: Trunk
Keywords: Cc:

Description

the patch 120-openwrt_options.patch for dropbear 0.53 disables inetd mode (#define INETD_MODE), which is a regression from the 0.52 package.

This not only caught me by surprise since I'm using inetd to run my daemons, but it is unecessary: The deamon with inetd mode enabled does *not* have a larger filesize - I'd advise to re-enable it by default, since it doesn't hurt anyone but might confuse some unsuspecting legacy users like me.

Attachments (1)

re-allow-inetd-mode-in-dropbear.patch (520 bytes) - added by Dave Taht <d@…> 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by jow

  • Owner changed from developers to kerneis
  • Status changed from new to assigned

comment:2 Changed 7 years ago by jow

  • Owner changed from kerneis to kaloz

-EUSER

comment:3 Changed 7 years ago by anonymous

I agree... Moreover, as for me I'd like to have an option to install kind of "full-featured" dropbear rather than get "disabled-everything-by-default" version to save only 10-15k of free space, which seem insignificant to me.
Sure, one can simply delete 120-openwrt_options.patch file to approach this, but it would be nice to be able to choose install this patch or not by some menuconfig option.

comment:4 Changed 7 years ago by Dave Taht <d@…>

+1 on this

--- a/package/dropbear/patches/120-openwrt_options.patch
+++ b/package/dropbear/patches/120-openwrt_options.patch
@@ -1,14 +1,5 @@

--- a/options.h
+++ b/options.h

-@@ -38,7 +38,7 @@

  • * Both of these flags can be defined at once, don't compile without at least
  • * one of them. */
  • #define NON_INETD_MODE

--#define INETD_MODE
-+/*#define INETD_MODE*/

  • /* Setting this disables the fast exptmod bignum code. It saves ~5kB, but is
  • * perhaps 20% slower for pubkey operations (it is probably worth experimentin

Changed 7 years ago by Dave Taht <d@…>

comment:5 Changed 7 years ago by Dave Taht <d@…>

grumble. please ignore my attempt at unpatching the patch. It's straightforward but it got mangled on the way

comment:6 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as assigned .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.