Modify

Opened 7 years ago

Closed 7 years ago

#8934 closed defect (fixed)

miniupnpd unable to delete rules from

Reported by: KillaB Owned by: developers
Priority: normal Milestone: Backfire 10.03.1
Component: packages Version: Backfire 10.03.1 RC4
Keywords: upnp ar71xx Cc: jow

Description

TL-WR1043ND running Backfire (10.03, r25480), miniupnpd - 1.5-5

miniupnpd[2074]: SOAPAction: urn:schemas-upnp-org:service:WANIPConnection:1#AddPortMapping
miniupnpd[2074]: AddPortMapping: ext port 23724 to 192.168.1.166:23724 protocol UDP for: FreeSWITCH
miniupnpd[2074]: no permission rule matched : accept by default (n_perms=0)
miniupnpd[2074]: redirecting port 23724 to 192.168.1.166:23724 protocol UDP for: FreeSWITCH
miniupnpd[2074]: HTTP connection from 192.168.1.166:46359
miniupnpd[2074]: HTTP REQUEST : POST /ctl/IPConn (HTTP/1.1)
miniupnpd[2074]: SOAPAction: urn:schemas-upnp-org:service:WANIPConnection:1#AddPortMapping
miniupnpd[2074]: AddPortMapping: ext port 23725 to 192.168.1.166:23725 protocol UDP for: FreeSWITCH
miniupnpd[2074]: no permission rule matched : accept by default (n_perms=0)
miniupnpd[2074]: redirecting port 23725 to 192.168.1.166:23725 protocol UDP for: FreeSWITCH
miniupnpd[2074]: HTTP connection from 192.168.1.166:46360
miniupnpd[2074]: HTTP REQUEST : POST /ctl/IPConn (HTTP/1.1)
miniupnpd[2074]: SOAPAction: urn:schemas-upnp-org:service:WANIPConnection:1#DeletePortMapping
miniupnpd[2074]: DeletePortMapping: external port: 23724, protocol: UDP
miniupnpd[2074]: removing redirect rule port 23724 UDP
miniupnpd[2074]: Trying to delete rules at index 4
miniupnpd[2074]: HTTP connection from 192.168.1.166:46361
miniupnpd[2074]: HTTP REQUEST : POST /ctl/IPConn (HTTP/1.1)
miniupnpd[2074]: SOAPAction: urn:schemas-upnp-org:service:WANIPConnection:1#DeletePortMapping
miniupnpd[2074]: DeletePortMapping: external port: 23725, protocol: UDP
miniupnpd[2074]: removing redirect rule port 23725 UDP
miniupnpd[2074]: Trying to delete rules at index 4

root@OpenWrt:/tmp/log# iptables -L MINIUPNPD   
Chain MINIUPNPD (1 references)
target     prot opt source               destination         
ACCEPT     udp  --  anywhere             192.168.1.166       udp dpt:5060 
ACCEPT     tcp  --  anywhere             192.168.1.166       tcp dpt:5060 
ACCEPT     udp  --  anywhere             192.168.1.166       udp dpt:5080 
ACCEPT     tcp  --  anywhere             192.168.1.166       tcp dpt:5080 
ACCEPT     udp  --  anywhere             192.168.1.166       udp dpt:26148 
ACCEPT     udp  --  anywhere             192.168.1.166       udp dpt:26149 
ACCEPT     udp  --  anywhere             192.168.1.166       udp dpt:23724 
ACCEPT     udp  --  anywhere             192.168.1.166       udp dpt:23725 

Attachments (2)

versionstring.patch (413 bytes) - added by KillaB 7 years ago.
1.5.20110302.patch (441 bytes) - added by KillaB 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by KillaB

Confirmed the problem does not exist with libupnp - 1.6.8-1 from snapshots.

comment:2 Changed 7 years ago by KillaB

Unfortunately there is still a nasty memory leak in libupnp - 1.6.8-1 causing my router to reboot or lockup approx. every 6-10 hours.

comment:3 Changed 7 years ago by KillaB

Furthermore, I don't know if this is a problem with FreeSWITCH miniupnpc code or miniupnpd code on OpenWrt, but I do not see a UPnP signoff packet on FS_CLI when stopping miniupnpd. I do however see multicast packets from 192.168.1.1 on port 1900 when I shutdown miniupnpd.

The following is observed on FS_CLI when stopping libupnp.
[WARNING] switch_nat.c:308 got UPnP signoff packet. Your NAT gateway is probably going offline.

comment:4 Changed 7 years ago by KillaB

Compiled and tested miniupnpd-1.5.20110221. This version is able to delete rules from iptables.

2011/01/27:
Reverting "fixes" done in linux/iptables code the 2010/09/27.
see http://miniupnp.tuxfamily.org/forum/viewtopic.php?t=741

Had troubles compiling until I edited the version string in upnphttp.h

Changed 7 years ago by KillaB

comment:5 Changed 7 years ago by KillaB

Patch supplied is just a hack, not meant to be a final patch. I would supply one, but I don't know the proper config changes necessary.

Quote from miniupnd dev:

Instead of changing upnphttp.h, you should ensure that MINIUPNPD_VERSION
is defined in config.h !

comment:6 Changed 7 years ago by KillaB

Thanks to Thomas Bernard, miniupnpd-1.5.20110302 now compiles without issue.
Please update and close ticket.

Changed 7 years ago by KillaB

comment:7 Changed 7 years ago by cshore

  • Resolution set to fixed
  • Status changed from new to closed

I've done a better fix for the long term, which is to not only update the package, but to change (currently by local patch, eventually upstream) from using a static config.h.openwrt to get a config.h to a dynamically generated one using the same script as generates the config for other platforms (after patching the script to work correctly with both openwrt and hopefully the other platforms).

Fixed commit: 25887

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.