Modify

Opened 7 years ago

Closed 2 years ago

#8694 closed enhancement (moved_to_github)

Set upload/download to kilobits (1000 bits) in miniupnpd UCI config to match dsl rate units [r25047]

Reported by: anonymous Owned by: cshore
Priority: low Milestone: Barrier Breaker 14.07
Component: packages Version: Trunk
Keywords: Cc:

Description

Despite xDSL rates are commonly provided in Kilobits (1kbit = 1000 bytes) /etc/init.d/miniupnpd currently expect upload/downlad rates (/etc/config/upnpd) specidied in kibibytes (1KiB = 1024 bits) and coverts these values to miniupnpd required units (bits):

		[ -n "$upload" -a -n "$download" ] && \
			append args "-B $(($download * 1024 * 8)) $(($upload * 1024 * 8))"

Such unit conversions actually prevent users to specify exact upload/download bitrates.

In fact to specify 10000 (kbit) an use would have to input 1220.703125 (KiB)

It would be far more accurate to have UCI save values in kbit (1000 bytes)

		[ -n "$upload" -a -n "$download" ] && \
			append args "-B $(($download * 1000)) $(($upload * 1000))"

Attachments (1)

miniupnpd.init.patch (436 bytes) - added by anonymous 7 years ago.
patch

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by anonymous

patch

comment:2 Changed 7 years ago by anonymous

In my early post I wrote incorrect units in parenthesized values for KiB and kbit
1KiB = 1024 bytes
1kbit = 1000 bits

comment:3 Changed 7 years ago by swalker

  • Owner changed from developers to cshore
  • Status changed from new to assigned

comment:4 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

comment:5 Changed 2 years ago by nbd

  • Resolution set to moved_to_github
  • Status changed from assigned to closed

miniupnpd is maintained here: ​https://github.com/openwrt-routing/packages

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.