e2fsprogs-1.41.12 #include ordering bug (leads to types.h re-define errors)

[Michael Evans <mjevans1983@…>]

build_dir/target-mipsel_uClibc-0.9.30.1/e2fsprogs-1.41.12/misc/filefrag.c

Should be patched like...

--- build_dir/target-mipsel_uClibc-0.9.30.1/e2fsprogs-1.41.12/misc/filefrag.c      2010-10-20 18:28:41.411831204 -0700
+++ build_dir/target-mipsel_uClibc-0.9.30.1/e2fsprogs-1.41.12/misc/filefrag.c   2010-10-20 18:29:35.638022702 -0700
@@ -39,8 +39,8 @@
 #include <sys/vfs.h>
 #include <sys/ioctl.h>
 #include <linux/fd.h>
-#include <ext2fs/ext2_types.h>
 #include <ext2fs/fiemap.h>
+#include <ext2fs/ext2_types.h>
 
 int verbose = 0;
 int no_bs = 0;         /* Don't use the files blocksize, use 1K blocksize */

in order to prevent this from happening.

        CC filefrag.c
In file included from /media/stuff/src/openwrt/dev/trunk/staging_dir/toolchain-mipsel_gcc-4.3.3+cs_uClibc-0.9.30.1/usr/include/asm/types.h:21,
                 from /media/stuff/src/openwrt/dev/trunk/staging_dir/toolchain-mipsel_gcc-4.3.3+cs_uClibc-0.9.30.1/usr/include/linux/types.h:4,
                 from ../lib/ext2fs/fiemap.h:14,
                 from filefrag.c:43:
/media/stuff/src/openwrt/dev/trunk/staging_dir/toolchain-mipsel_gcc-4.3.3+cs_uClibc-0.9.30.1/usr/include/asm-generic/int-ll64.h:19: error: redefinition of typedef '__s8'
../lib/ext2fs/ext2_types.h:26: error: previous declaration of '__s8' was here
/media/stuff/src/openwrt/dev/trunk/staging_dir/toolchain-mipsel_gcc-4.3.3+cs_uClibc-0.9.30.1/usr/include/asm-generic/int-ll64.h:20: error: redefinition of typedef '__u8'
../lib/ext2fs/ext2_types.h:20: error: previous declaration of '__u8' was here
/media/stuff/src/openwrt/dev/trunk/staging_dir/toolchain-mipsel_gcc-4.3.3+cs_uClibc-0.9.30.1/usr/include/asm-generic/int-ll64.h:22: error: redefinition of typedef '__s16'
../lib/ext2fs/ext2_types.h:46: error: previous declaration of '__s16' was here
/media/stuff/src/openwrt/dev/trunk/staging_dir/toolchain-mipsel_gcc-4.3.3+cs_uClibc-0.9.30.1/usr/include/asm-generic/int-ll64.h:23: error: redefinition of typedef '__u16'
../lib/ext2fs/ext2_types.h:32: error: previous declaration of '__u16' was here
/media/stuff/src/openwrt/dev/trunk/staging_dir/toolchain-mipsel_gcc-4.3.3+cs_uClibc-0.9.30.1/usr/include/asm-generic/int-ll64.h:25: error: redefinition of typedef '__s32'
../lib/ext2fs/ext2_types.h:79: error: previous declaration of '__s32' was here
/media/stuff/src/openwrt/dev/trunk/staging_dir/toolchain-mipsel_gcc-4.3.3+cs_uClibc-0.9.30.1/usr/include/asm-generic/int-ll64.h:26: error: redefinition of typedef '__u32'
../lib/ext2fs/ext2_types.h:61: error: previous declaration of '__u32' was here
/media/stuff/src/openwrt/dev/trunk/staging_dir/toolchain-mipsel_gcc-4.3.3+cs_uClibc-0.9.30.1/usr/include/asm-generic/int-ll64.h:29: error: redefinition of typedef '__s64'
../lib/ext2fs/ext2_types.h:113: error: previous declaration of '__s64' was here
/media/stuff/src/openwrt/dev/trunk/staging_dir/toolchain-mipsel_gcc-4.3.3+cs_uClibc-0.9.30.1/usr/include/asm-generic/int-ll64.h:30: error: redefinition of typedef '__u64'
../lib/ext2fs/ext2_types.h:97: error: previous declaration of '__u64' was here
make[6]: *** [filefrag.o] Error 1
make[6]: Leaving directory `/media/stuff/src/openwrt/dev/trunk/build_dir/target-mipsel_uClibc-0.9.30.1/e2fsprogs-1.41.12/misc'
make[5]: *** [all-progs-recursive] Error 1
make[5]: Leaving directory `/media/stuff/src/openwrt/dev/trunk/build_dir/target-mipsel_uClibc-0.9.30.1/e2fsprogs-1.41.12'
make[4]: *** [all] Error 2
make[4]: Leaving directory `/media/stuff/src/openwrt/dev/trunk/build_dir/target-mipsel_uClibc-0.9.30.1/e2fsprogs-1.41.12'
make[3]: *** [/media/stuff/src/openwrt/dev/trunk/build_dir/target-mipsel_uClibc-0.9.30.1/e2fsprogs-1.41.12/.built] Error 2
make[3]: Leaving directory `/media/stuff/src/openwrt/dev/trunk/package/e2fsprogs'
make[2]: *** [package/e2fsprogs/compile] Error 2
make[2]: Leaving directory `/media/stuff/src/openwrt/dev/trunk'
make[1]: *** [/media/stuff/src/openwrt/dev/trunk/staging_dir/target-mipsel_uClibc-0.9.30.1/stamp/.package_compile] Error 2
make[1]: Leaving directory `/media/stuff/src/openwrt/dev/trunk'
make: *** [world] Error 2

[Michael Evans <mjevans1983@…>]

As an alternative fix I did not encounter this problem even though there was no patch for it when I switched to uClibc-0.9.32 and gcc-4.4.1 (from 4.3.3) and then ran make clean ; rm -r build_dir/*

Now I can't even find files under staging_dir/toolchain-mipsel_gcc-4.4.1+cs_uClibc-0.9.32/usr/include/ so I'm unsure if it's a compiler, libc, or install fix that simply cropped up due to a months stale toolchain.

[florian]

Fixed with the update to a newer uClibc version.

[jow]

Milestone Attitude Adjustment 12.09 deleted