Modify ↓
#8042 closed defect (fixed)
redundant SH_FUNC for unpack
Reported by: | moo.tinys@… | Owned by: | nbd |
---|---|---|---|
Priority: | normal | Milestone: | Barrier Breaker 14.07 |
Component: | toolchain | Version: | Trunk |
Keywords: | Cc: |
Description
problem:
make[3]: Entering directory `/home/moo/src/openwrt-trunk/feeds/packages/net/cups' WARNING: skipping cups -- package not selected . /home/moo/src/openwrt-trunk/include/shell.sh; . /home/moo/src/openwrt-trunk/include/shell.sh; bzcat /home/moo/src/openwrt-trunk/dl/cups-1.4.2-source.tar.bz2 | /usr/bin/gtar -C /home/moo/src/openwrt-trunk/build_dir/target-i386_glibc-2.7/cups-1.4.2/.. -xf -
expected: there should be just 1 include to shell.sh
in include/package-defaults.mk
Build/Patch:=$(Build/Patch/Default) ifneq ($(strip $(PKG_UNPACK)),) define Build/Prepare/Default $(SH_FUNC) $(PKG_UNPACK) $(Build/Patch) endef endif
in include/unpack.mk
ifdef PKG_BUILD_DIR PKG_UNPACK ?= $(SH_FUNC) $(call UNPACK_CMD,$(PKG_BUILD_DIR)) $(call CRLF_CMD,$(PKG_BUILD_DIR)) endif }}}suggested fix: replace $(SH_FUNC) $(PKG_UNPACK) into $(PKG_UNPACK) in include/package-defaults.mk
Attachments (0)
Change History (3)
comment:1 Changed 6 years ago by swalker
- Owner changed from developers to nbd
- Status changed from new to assigned
comment:2 Changed 6 years ago by nbd
- Resolution set to fixed
- Status changed from assigned to closed
comment:3 Changed 4 years ago by jow
- Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07
Milestone Attitude Adjustment 12.09 deleted
Note: See
TracTickets for help on using
tickets.
fixed in r30818