Modify

Opened 8 years ago

Last modified 4 years ago

#7509 new defect

muninlite uses ethtool but does not depend on it

Reported by: Ahmad Khayyat <akhayyat@…> Owned by: developers
Priority: normal Milestone: Chaos Calmer 15.05
Component: packages Version: Backfire 10.03
Keywords: munin, ethtool Cc:

Description

muninlite uses ethtool to get the max speed of each interface, but does not depend on the ethtool package.

However, ethtool is not very useful, at least not on my router. It shows the interface speed only for the eth1 interface. As it is not critical for the operation of muninlite, maybe the muninlite code using ethtool should be removed:

if ethtool $1 | grep -q Speed; then
   MAX=$(($(ethtool $1 | grep Speed | sed -e 's/[[:space:]]\{1,\}/ /g' -e 's/^ //' -e 's/M.*//' | cut -d\  -f2) * 1000000))
   echo "up.max $MAX" 
   echo "down.max $MAX"
fi 

I have had no problems commenting this if block.

Attachments (0)

Change History (1)

comment:1 Changed 4 years ago by jow

  • Milestone changed from Backfire 10.03.2 to Chaos Calmer (trunk)

Milestone Backfire 10.03.2 deleted

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.