Modify

Opened 8 years ago

Closed 8 years ago

Last modified 4 years ago

#7477 closed defect (fixed)

Missing dir ~include/asm-mips breaks build on brcm47xx WGT634U builld

Reported by: Brian Capouch <brianc@…> Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: toolchain Version: Trunk
Keywords: Cc:

Description

I couldn't get 21808 to build without creating the directory `/linux-2.6.32.14/include/asm-mips.

This patch probably isn't the right one, but it seemed to work.

Attachments (1)

patch.txt (508 bytes) - added by Brian Capouch <brianc@…> 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by Brian Capouch <brianc@…>

comment:1 follow-up: Changed 8 years ago by nbd

rather than just adding the directory, i'd like to know why it is even necessary in the first place

comment:2 in reply to: ↑ 1 Changed 8 years ago by Brian Capouch <brianc@…>

Replying to nbd:

rather than just adding the directory, i'd like to know why it is even necessary in the first place

The build fails! There is a copy in ~toolchain/kernel-headers/Makefile (referenced in the patch) and if the target directory isn't there the build bombs out.

comment:3 Changed 8 years ago by nbd

sounds like toolchain/kernel-headers/Makefile should be fixed then (instead of just hiding the bug).

comment:4 Changed 8 years ago by Brian Capouch <brianc@…>

Well the build alchemy is too deep for my understanding. Below is a short snippet of the older Makefile, followed by the equivalent current on that doesn't work. Perhaps the logic for LINUX_HAS_HEADERS_INSTALL is where the problem lies? Sorry I can't be of more help.

snip one -- works
define Host/Prepare

$(call Kernel/Prepare/Default)
ln -sf linux-$(LINUX_VERSION) $(BUILD_DIR_TOOLCHAIN)/linux
$(SED) 's/@expr length/@-expr length/' $(HOST_BUILD_DIR)/Makefile
yes | $(KMAKE) oldconfig
$(KMAKE) include/linux/version.h include/asm
if [ -d $(HOST_BUILD_DIR)/arch/$(LINUX_KARCH)/include/asm ]; then \

$(CP) \

$(HOST_BUILD_DIR)/arch/$(LINUX_KARCH)/include/asm/. \
$(HOST_BUILD_DIR)/include/asm-$(LINUX_KARCH)/; \

fi
$(call Host/Prepare/pre/$(ARCH))
$(call Host/Prepare/all)
$(call Host/Prepare/post/$(ARCH))

endef

snip two -- blows up
ifneq ($(LINUX_HAS_HEADERS_INSTALL),)

define Host/Prepare/all

$(KMAKE) \

INSTALL_HDR_PATH="$(BUILD_DIR_TOOLCHAIN)/linux-dev/usr/" \
headers_install

if [ -d $(HOST_BUILD_DIR)/arch/$(LINUX_KARCH)/include/asm ]; then \

$(CP) \

$(HOST_BUILD_DIR)/arch/$(LINUX_KARCH)/include/asm/. \
$(HOST_BUILD_DIR)/include/asm-$(LINUX_KARCH)/; \

fi

endef

else

define Host/Prepare/all

$(KMAKE) include/linux/version.h include/asm
mkdir -p $(BUILD_DIR_TOOLCHAIN)/linux-dev/usr/include
cp -pLR $(HOST_BUILD_DIR)/include/asm $(BUILD_DIR_TOOLCHAIN)/linux-dev/usr/include/
cp -pLR $(HOST_BUILD_DIR)/include/asm-generic $(BUILD_DIR_TOOLCHAIN)/linux-dev/usr/include/
cp -pLR $(HOST_BUILD_DIR)/include/asm-$(LINUX_KARCH) $(BUILD_DIR_TOOLCHAIN)/linux-dev/usr/inc

lude/

cp -pLR $(HOST_BUILD_DIR)/include/linux $(BUILD_DIR_TOOLCHAIN)/linux-dev/usr/include/

endef

endif

comment:5 Changed 8 years ago by nico

  • Resolution set to fixed
  • Status changed from new to closed

Should be fixed in [21843], thanks !

comment:6 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.