Modify

Opened 8 years ago

Closed 7 years ago

Last modified 4 years ago

#7272 closed defect (no_response)

b43 finds empty sprom data, sets zero mac-address

Reported by: datenritter Owned by: hauke
Priority: normal Milestone: Barrier Breaker 14.07
Component: kernel Version: Trunk
Keywords: Cc:

Description (last modified by hauke)

In b43_wireless_init() sprom->il0mac is not checked for validity, so an invalid mac-address of 00:00:00:00:00:00 ist set. Wifi doesn't work then.

I have a WRT54G3GV2-VF. Wireless is 4318 rev 9.

I couldn't go deeper into the code, so I just put a fallback-address in the driver. If you used the attached patch, you'd get something like this:

Configuring kmod-b43.
b43_probe: board_rev 0 country_code 0 ant-a 0 ant-bg 0
b43_probe: 0:0:0:0:0:0 (et0mac)
b43_probe: 0:0:0:0:0:0 (et1mac)
b43_probe: 0:0:0:0:0:0 (il0mac)
b43_probe calling b43_wireless_init...
b43 set mac-address to 0:ab:cd:ab:cd:ab (mymac)
b43-phy5: Broadcom 4318 WLAN found (core revision 9)
Broadcom 43xx driver loaded [ Features: PL, Firmware-ID: FW13 ]

All the sprom fields seem to be zero.

Attachments (1)

990-my-local-changes.patch (2.4 KB) - added by datenritter 8 years ago.
some stupid printks and a fixed fallback mac address for b43

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by datenritter

some stupid printks and a fixed fallback mac address for b43

comment:1 Changed 8 years ago by datenritter

http://pastebin.com/vANshia6 fixes this. (ask rtz for details.)

comment:2 Changed 8 years ago by hauke

  • Description modified (diff)
  • Owner changed from developers to hauke
  • Status changed from new to assigned

Thank you for the patch, but before applying it, please try recent trunk and post the output of "nvram show" (have a look at the output before posting and remove passwords)

comment:3 Changed 8 years ago by Osa

Latest trunk build does not solve the problem.

root@OpenWrt:/# nvram show                                                      
boardnum=42                                                                     
boot_ver=v5.5                                                                   
pa0b0=0x170c                                                                    
pci/1/1/pa0maxpwr=0x4e                                                          
pa0b1=0xfa24                                                                    
pa0b2=0xfe70                                                                    
led_gpio3=3                                                                     
led_gpio4=4                                                                     
led_gpio2=2                                                                     
pci/1/1/pa0itssit=62                                                            
mfg_wait=on                                                                     
sdram_ncdl=0x307                                                                
boot_hw_ver=1.0                                                                 
pa0maxpwr=0x48                                                                  
pa0itssit=62                                                                    
wl0gpio2=0                                                                      
wl0gpio3=0                                                                      
ag0=255                                                                         
et1mdcport=1                                                                    
pci/1/1/ag0=0x02                                                                
il0macaddr=00:23:69:5c:87:15                                                    
pci/1/1/wl0gpio1=1                                                              
pci/1/1/wl0gpio2=11                                                             
pci/1/1/wl0gpio3=11                                                             
pci/1/1/wl0gpio0=2                                                              
boot_from=1                                                                     
sdram_config=0x0062                                                             
aa0=3                                                                           
pci/1/1/aa0=0x03                                                                
wl0id=0x4320                                                                    
lan_netmask=255.255.255.0                                                       
sromrev=2                                                                       
reset_gpio=6                                                                    
et0macaddr=00:23:69:5C:87:13                                                    
os_ram_addr=80001000                                                            
et1phyaddr=5                                                                    
dl_ram_addr=a0001000                                                            
image_status=IMG_SAME                                                           
sdram_init=0x0009                                                               
boot_hw_model=WRT54G3GV2-VF                                                     
et0phyaddr=30                                                                   
boardflags=0x0018                                                               
pci/1/1/il0macaddr=00:90:4C:8D:00:2a                                            
led_dual_led=on                                                                 
clkfreq=264                                                                     
lan_ipaddr=192.168.1.1                                                          
tftpd_ipaddr=192.168.1.254                                                      
boardtype=0x042f                                                                
et1macaddr=00:90:4C:60:00:2B                                                    
pmon_ver=CFE 4.151.10.5                                                         
boot_wait=off                                                                   
bootnv_ver=3                                                                    
boardrev=0x10                                                                   
opo=0x0                                                                         
pci/1/1/devid=0x4318                                                            
pci/1/1/ccode=0                                                                 
pci/1/1/opo=14                                                                  
sdram_refresh=0x0000                                                            
ccode=0                                                                         
scratch=a0180000                                                                
cctl=0                                                                          
pci/1/1/boardtype=0x449                                                         
pci/1/1/boardrev=0x40                                                           
pci/1/1/sromrev=2                                                               
pci/1/1/boardflags=0xe248                                                       
os_flash_addr=bfc40000                                                          
et0mdcport=0                                                                    
pci/1/1/pa0b0=0x1460                                                            
watchdog=5000                                                                   
pci/1/1/pa0b1=0xfacb                                                            
pci/1/1/pa0b2=0xfe5c
root@OpenWrt:/# wifi detect                                                     
config wifi-device  radio1                                                      
        option type     mac80211                                                
        option channel  5                                                       
        option macaddr  00:00:00:00:00:00                                       
        option hwmode   11g                                                     
                                                                                
        # REMOVE THIS LINE TO ENABLE WIFI:                                      
        option disabled 1                                                       
                                                                                
config wifi-iface                                                               
        option device   radio1                                                  
        option network  lan                                                     
        option mode     ap                                                      
        option ssid     OpenWrt                                                 
        option encryption none                                                  
                             

comment:4 Changed 7 years ago by nico

  • Milestone changed from Backfire 10.03.1 to Kamikaze

comment:5 Changed 7 years ago by hauke

Does this problem still occur in recent trunk?

I think the mac addresses are read out in arch/mips/bcm47xx/setup.c

comment:6 Changed 7 years ago by hauke

  • Resolution set to no_response
  • Status changed from assigned to closed

Closed because of no response. Please reopen the ticket if this problem still occurs in trunk.

comment:7 Changed 7 years ago by hauke

Problem fixed in r26801.

comment:8 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.