Modify

Opened 8 years ago

Closed 8 years ago

Last modified 4 years ago

#7091 closed defect (no_response)

r20358 removes vlan support for many ag71xx devices

Reported by: Will Dyson <will.dyson@…> Owned by: juhosg
Priority: normal Milestone: Barrier Breaker 14.07
Component: kernel Version: Trunk
Keywords: ag71xx ar71xx Cc:

Description

In r20358, the phy_mask parameter is removed from the setup for one of the ethernet interfaces on many ar71xx boards.

Without a phy_mask parameter, ag71xx_phy_connect_fixed() is called instead of ag71xx_phy_connect_multi().

ag71xx_phy_connect_fixed() never actually calls phy_connect(), so no switch is registered with the kernel.

root@OpenWrt:~# swconfig dev eth0 show
Failed to connect to the switch

I'm not sure that the switch actually worked correctly on these devices, so perhaps it was intentional. But the commit message gives no hint of that.

Attachments (0)

Change History (4)

comment:1 Changed 8 years ago by thepeople

  • Owner changed from developers to juhosg
  • Status changed from new to assigned

comment:2 Changed 8 years ago by KanjiMonster

The old behaviour was that phy_connect() was only called if phy_connect_multi() found exactly one phy on the addresses from the PHY_MASK. If the PHY_MASK was zero or more than one was found, phy_connect_fixed() was called.

The new behaviour changes that to phy_connect() gets called if the phy_connect_multi() find one or more phys on the miibus on the addresses from PHY_MASK.

Therefore any device which had a PHY_MASK with more than one bit set or no PHY_MASK set should see no change in behaviour, if the new PHY_MASK was changed to zero/unset.

The only way there could be a change is if the PHY_MASK has several bits set, but only on one of these addresses is a phy.

So its quite unlikely that the switch worked before, but without knowing which device this is, there's no way of telling that.

comment:3 Changed 8 years ago by nbd

  • Resolution set to no_response
  • Status changed from assigned to closed

comment:4 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.