Modify

Opened 8 years ago

Closed 8 years ago

Last modified 4 years ago

#6757 closed defect (fixed)

unnecessary compile option on dnsmasq

Reported by: Leonardo Rodrigues <leolistas@…> Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: packages Version: Kamikaze trunk
Keywords: dnsmasq Cc:

Description

To avoid confuse by some user, i think the compile option

-DHAVE_ISC_READER=1

should be removed from compile options of dnsmasq. That option used to enable reading ISC-DHCP lease files, but it was completly removed on dnsmasq 2.46 (actual version is 2.52). There's no problem using this compile option. It's deprecated and, in fact, does absolutely nothing. The idea is just to avoid some user searching for that on Google and think that dnsmasq can still read ISC-DHCP lease files. According to dnsmasq Changelog:

version 2.46

            Remove ISC-leasefile reading code. This has been
            deprecated for a long time, and last time I removed it, it
            ended up going back by request of one user. This time,   
            it's gone for good; otherwise it would need to be
            re-worked to support multiple domains (see below).

patching it would be as simply as:

[solutti@f8 dnsmasq]$ diff -Naur Makefile.old Makefile
--- Makefile.old        2010-02-28 07:24:22.000000000 -0300
+++ Makefile    2010-02-28 07:24:47.000000000 -0300
@@ -36,7 +36,7 @@
 define Build/Compile
        $(MAKE) -C $(PKG_BUILD_DIR) \
                $(TARGET_CONFIGURE_OPTS) \
-               CFLAGS="$(TARGET_CFLAGS) -DHAVE_ISC_READER=1" \
+               CFLAGS="$(TARGET_CFLAGS)" \
                BINDIR="/usr/sbin" MANDIR="/usr/man" \
                AWK="awk" \
                all
[solutti@f8 dnsmasq]$ 

Attachments (0)

Change History (2)

comment:1 Changed 8 years ago by acinonyx

  • Resolution set to fixed
  • Status changed from new to closed

Applied in 19942. Thanks!

comment:2 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.