Modify

Opened 12 years ago

Closed 12 years ago

#604 closed defect (worksforme)

atheros not detected with RC5, worked in RC4 -- mdelay() removed from bcm947xx/pcibios.c

Reported by: bcrl@… Owned by: developers
Priority: normal Milestone:
Component: packages Version:
Keywords: Cc:

Description

In linux.dev/arch/mips/bcm947xx/pcibios.c, -rc4 has:

in pcibios_init()
...

set_io_port_base((unsigned long) ioremap_nocache(SB_PCI_MEM, 0x04000000));

-> mdelay(300); By Joey for Atheros Card

/* Scan the SB bus */
pci_scan_bus(0, &pcibios_ops, NULL);

...

whereas -RC5 removed the mdelay(). Without the mdelay(300), my Atheros cards are not detected.

Attachments (1)

fix-wr850g.diff (579 bytes) - added by bcrl@… 12 years ago.
fix WR850Gv1 PCI not being scanned

Download all attachments as: .zip

Change History (4)

comment:1 Changed 12 years ago by bcrl@…

Hrmmm, that isn't all that's needed. Cold booting doesn't work with only that change.

Changed 12 years ago by bcrl@…

fix WR850Gv1 PCI not being scanned

comment:2 Changed 12 years ago by bcrl@…

The actual cause seems to be that pci_disabled is being set for the 4710 rev 0 (as in my WR850G). The original code in -RC4 was comparing chip to 4310. Changing this lets the pci bus get scanned on my WR850Gv1

comment:3 Changed 12 years ago by nbd

  • Resolution set to worksforme
  • Status changed from new to closed

That diff looks wrong to me. I can't find the comparison with 0x4710 in RC5. Did you check out trunk by accident?

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.