Modify

Opened 8 years ago

Closed 5 years ago

Last modified 4 years ago

#5876 closed defect (obsolete)

add support for APC UPS with usb cable: bug in hid-core

Reported by: nervous@… Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: kernel Version:
Keywords: Cc:

Description

Kernel 2.6.25.20 (from 8.09.1) and 2.6.28.10 (from trunk) contain a bug that prevents most APC UPS to be correctly claimed by the HID driver.

The problem lies in the following check:

if (parser->global.logical_maximum <= parser->global.logical_minimum) {

around line 216.

In the case of many APC UPS (I have an APC Back-UPS RS800) global.logical_maximum and global.logical_minimum are equal.
The check should be relaxed to:

if (parser->global.logical_maximum <= parser->global.logical_minimum) {

Recent kernels apparently already have this fix.
Please include it in the next Kamikaze release.

Attachments (1)

hid-core.c.patch (421 bytes) - added by anonymous 8 years ago.
patch for hid-core.c

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by anonymous

patch for hid-core.c

comment:1 Changed 8 years ago by anonymous

Sorry, I made a mistake in the cut/paste:

the kernel as shipped with Kamikaze 8.09.1 and trunk contains:

if (parser->global.logical_maximum < parser->global.logical_minimum) {

without the equal sign of course!

comment:2 Changed 8 years ago by anonymous

Trac allows you to replace/reupload the existing attachment...

comment:3 Changed 8 years ago by florian

You should either fix apc ups or send this patch mainline.

comment:4 Changed 5 years ago by nbd

  • Resolution set to obsolete
  • Status changed from new to closed

comment:5 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.