Modify

Opened 8 years ago

Closed 8 years ago

Last modified 4 years ago

#5790 closed defect (fixed)

Typo in Dnsmasq init script

Reported by: pverda@… Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: packages Version:
Keywords: Cc:

Description

Rev: 17511

Package: dnsmasq

File: dnsmasq.init

Line 246 reads: limit="$((${limit:-150} + 1))"
and it should read: limit="$((${limit:-150} - 1))"
With the plus sign the number of dhcp addresses is 152 instead of the intended 150 with a value of 150

Attachments (0)

Change History (5)

comment:1 Changed 8 years ago by anonymous

If you type 150 into LuCI, the value of limit is set at 149. Then the dnsmasq init script adds one to it bringing it back to 150, and ipcalc.sh removes 1 putting it again back to 149. So everything ends up working out.

Not sure why there's so many +1 here and -1 there on that particular value though... seems like frivolous complications.

comment:2 Changed 8 years ago by thepeople

  • Resolution set to fixed
  • Status changed from new to closed

fixed r20259

comment:3 Changed 8 years ago by peterv@…

This change broke startup of dnsmasq for me, from the log:

user.info sysinit: /etc/rc.common: eval: line 1: 150: not found

and the DHCP range is set to x.x.x.1-x.x.x.1.

comment:4 Changed 8 years ago by thepeople

Fixed, sorry about that.

comment:5 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.