Modify

Opened 12 years ago

Closed 12 years ago

#543 closed defect (fixed)

webif firewall.sh: cancel button does't work

Reported by: anonymous Owned by: florian
Priority: normal Milestone: 0.9/rc6
Component: packages Version:
Keywords: Cc:

Description

The cancel button on the firewall webif page does not work.

Attachments (2)

cancel_button.patch (1.8 KB) - added by anonymous 12 years ago.
This patch fixes the problem.
webif.firewall.sh (760 bytes) - added by david_s5 12 years ago.
Select Box Fix for - webif/firewall.sh

Download all attachments as: .zip

Change History (7)

comment:1 Changed 12 years ago by anonymous

yeah. the full firewall webif page does not worked for me

Changed 12 years ago by anonymous

This patch fixes the problem.

comment:2 Changed 12 years ago by florian

  • Owner changed from developers to florian
  • Status changed from new to assigned

comment:3 Changed 12 years ago by florian

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in [3809]

comment:4 Changed 12 years ago by david_s5

  • Resolution fixed deleted
  • Status changed from closed to reopened

The hidden hidden("delete_on_cancel", 1); is in the select list and broke the select box in IE 6

Fix:

Index: firewall.sh
===================================================================
--- firewall.sh	(revision 3815)
+++ firewall.sh	(working copy)
@@ -335,8 +335,8 @@
 	print "<tr><td class=\\"edit_title\\">@TR<<New Rule>>: </td><td colspan=\\"4\\">"
 	print "<form method=\\"POST\\" action=\\"$SCRIPT_NAME\\" enctype=\\"multipart/form-data\\">"
 	print hidden("edit", n + 1);
+	print hidden("delete_on_cancel", 1);
 	print "<select name=\\"new_target\\">"
-	print hidden("delete_on_cancel", 1);
 	print sel_option("forward", "Forward")
 	print sel_option("accept", "Accept")
 	print sel_option("drop", "Drop")

Changed 12 years ago by david_s5

Select Box Fix for - webif/firewall.sh

comment:5 Changed 12 years ago by florian

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in [3819], thanks !

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.