Modify

Opened 9 years ago

Closed 5 years ago

Last modified 4 years ago

#5271 closed enhancement (obsolete)

[PATCH] Always use DEFAULT_TARGET_OPTIMIZATION if not changed manually

Reported by: mss Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: packages Version: Trunk
Keywords: Cc:

Description

I recently ran into the following, hard to debug problem:

To easily test my image I originally built and configured it for x86 and debugged it with VirtualBox. While doing so I enabled DEVEL to switch on CCACHE and change the DOWNLOAD_FOLDER.

Later I switched the target to ar71xx and tried to rebuild, starting from a dirclean. But the build failed with some very odd errors. After staring at the make output for a long time I noticed that it tried to optimize the ar71xx build for i486 because switching on DEVEL also froze the value of TARGET_OPTIMIZATION.

I guess most people don't really need to change TARGET_OPTIMIZATION and/or should rely on the profile's default settings.

I'll attach a patch which hides TARGET_OPTIMIZATION behind a default-n menuconfig, which effectively make everybody use DEFAULT_TARGET_OPTIMIZATION if not explicitly selected.

It also makes it possible to actually toggle TARGETOPTS (default-y) so people who do want to use the recommended version of GCC etc while still changing more high level DEVEL options can do so.

Attachments (1)

toolchainopts.patch (1.5 KB) - added by mss 9 years ago.
Patch for menuconfig

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by mss

Patch for menuconfig

comment:1 Changed 5 years ago by jogo

  • Resolution set to obsolete
  • Status changed from new to closed

TARGET_OPTIMIZATION has been moved into a separate submenu with an extra guard, so this patch isn't needed anymore.

comment:2 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.