Modify

Opened 9 years ago

Closed 6 years ago

Last modified 4 years ago

#5168 closed defect (fixed)

RTSP conntrack module is broken

Reported by: mat Owned by: jow
Priority: response-needed Milestone: Barrier Breaker 14.07
Component: kernel Version:
Keywords: Cc:

Description

The RTSP conntrack module is broken on 2.6.28.10

First a "hlpr->tuple.src.l3num = AF_INET;" is missing in init, but other thing are broken...

Attachments (5)

191-netfilter_rtsp_fix.patch (18.1 KB) - added by macpaul@… 8 years ago.
Draft Patch fix for rtsp protocol from author's newest release (2.6.26) without DEBUG format merge without integrating merge 190-netfilter_rtsp.patch
191-netfilter_rtsp_fix.2.patch (4.0 KB) - added by macpaul@… 8 years ago.
New patch file of 191-netfilter_rtsp_fix.patch which I reformatted the debug message as the convension coding style of OpenWRT. Which also reduce the file size of 191-netfilter_rtsp_fix.patch.
190-netfilter_rtsp.patch (40.0 KB) - added by macpaul@… 8 years ago.
New "190-netfilter_rtsp.patch" which is merge "191-netfilter_rtsp_fix.patch". The final patch of rtsp feature for 2.6.26-2.6.32 kernel
190-netfilter_rtsp.2.patch (40.0 KB) - added by aorlinsk 8 years ago.
Fix a compile error in the previous posted patch of the same name. Works on 2.6.32.8 (r19886)
605-netfilter_rtsp.patch (39.6 KB) - added by fabroce <fabricedagorn@…> 7 years ago.
target/linux/generic/patches-2.6.37/605-netfilter_rtsp.patch

Download all attachments as: .zip

Change History (27)

comment:1 Changed 9 years ago by florian

If you can point to a patch that fixes the issues, we will certainly merge it.

comment:2 follow-up: Changed 8 years ago by macpaul @…

I've tried the following new patch from conntrack-rtsp author's website.
And it works on 2.6.30 + Kirkwood solution.

http://mike.it-loops.com/item/9
http://mike.it-loops.com/rtsp/rtsp-module-2.6.26.tar.gz

comment:3 in reply to: ↑ 2 ; follow-up: Changed 8 years ago by macpaul@…

You can use Apple's Darwin Media Streaming server + Quicktime client to do the rtsp streaming testing.

Darwin Streaming Server
http://developer.apple.com/opensource/server/streaming/index.html

Apple Quicktime Download
http://www.apple.com/quicktime/download/

Replying to macpaul @…:

I've tried the following new patch from conntrack-rtsp author's website.
And it works on 2.6.30 + Kirkwood solution.

http://mike.it-loops.com/item/9
http://mike.it-loops.com/rtsp/rtsp-module-2.6.26.tar.gz

Changed 8 years ago by macpaul@…

Draft Patch fix for rtsp protocol from author's newest release (2.6.26) without DEBUG format merge without integrating merge 190-netfilter_rtsp.patch

comment:4 in reply to: ↑ 3 Changed 8 years ago by anonymous

Replying to macpaul@…:

You can use Apple's Darwin Media Streaming server + Quicktime client to do the rtsp streaming testing.

Darwin Streaming Server
http://developer.apple.com/opensource/server/streaming/index.html

Apple Quicktime Download
http://www.apple.com/quicktime/download/

Replying to macpaul @…:

I've tried the following new patch from conntrack-rtsp author's website.
And it works on 2.6.30 + Kirkwood solution.

http://mike.it-loops.com/item/9
http://mike.it-loops.com/rtsp/rtsp-module-2.6.26.tar.gz

Will do merge 191-netfilter_rtsp_fix.patch and 190-netfilter_rtsp.patch into a single file 190-netfilter_rtsp.patch later.

Changed 8 years ago by macpaul@…

New patch file of 191-netfilter_rtsp_fix.patch which I reformatted the debug message as the convension coding style of OpenWRT. Which also reduce the file size of 191-netfilter_rtsp_fix.patch.

comment:5 Changed 8 years ago by macpaul@…

I reformatted the debug message and some coding style and generate a new patch "191-netfilter_rtsp_fix.2.patch" to replace the draft patch "191-netfilter_rtsp_fix.patch". "191-netfilter_rtsp_fix.2.patch" also fix the rtsp problem on kernel 2.6.30, however I change some coding style of debug message to make the formatting conformance with patch "190-netfilter_rtsp.patch" and OpenWRT. The file size of "191-netfilter_rtsp_fix.2.patch" is also smaller then previous draft file "191-netfilter_rtsp_fix.patch"

Changed 8 years ago by macpaul@…

New "190-netfilter_rtsp.patch" which is merge "191-netfilter_rtsp_fix.patch". The final patch of rtsp feature for 2.6.26-2.6.32 kernel

comment:6 Changed 8 years ago by thepeople

  • Owner changed from developers to jow
  • Status changed from new to assigned

Changed 8 years ago by aorlinsk

Fix a compile error in the previous posted patch of the same name. Works on 2.6.32.8 (r19886)

comment:7 Changed 8 years ago by aorlinsk

The last patch (190-netfilter_rtsp.patch) has 2 small compilation errors.... it works after I fixed them. I posted the patched patch.

Tested successfully on r19886 with kernel 2.6.32.8 on wndr3700.

comment:8 Changed 8 years ago by macpaul@…

Hey it's great! Have you commit this modification of patch into trunk? Since my last work I have no time to continue work on this issue. How did you edit the files directly? Do you get an account to login? :) Anyway, thanks a lot.

Changed 7 years ago by fabroce <fabricedagorn@…>

target/linux/generic/patches-2.6.37/605-netfilter_rtsp.patch

comment:9 follow-up: Changed 7 years ago by fabroce <fabricedagorn@…>

New patch 605-netfilter_rtsp.patch .
Works on trunk (r26972).

comment:10 in reply to: ↑ 9 ; follow-up: Changed 6 years ago by pierre.gaufillet@…

Unfortunately, rtsp conntrack still seems to be broken on trunk and backfire (r28490). Any clue about what needs to be done to restore this feature? It is especially useful in France where a major ISP provides TV streams using RTSP.

comment:11 in reply to: ↑ 10 Changed 6 years ago by fabroce

Did you try my patch ?
I don't know if kernel version is still 2.6.37 but in any case, it would not be too hard to patch the patch!

comment:12 Changed 6 years ago by pierre.gaufillet@…

Yep, but I got no better results. Either I deployed it in the wrong way, or it is not adapted to kernels 2.6.39. Anyway, how do you proceed to patch the patch ;-)? Is there a debugging mode?

comment:13 Changed 6 years ago by jow

  • Priority changed from normal to response-needed
  • Status changed from assigned to accepted

I removed the complete old RTSP implementation from trunk and added http://mike.it-loops.com/rtsp/rtsp-module-2.6.36.tar.gz to the xtables-addons package. RTSP conntrack support is available as "kmod-ipt-nathelper-rtsp" from now on. Please try the new implementation and add feedback here.

comment:14 Changed 6 years ago by jow

Relevant changesets: r29643, r29644

comment:15 Changed 6 years ago by pierre.gaufillet@…

It works on wrt54gs (brcm47xx, Linux 3.0.x). I will test it soon on a wndr3700.

Many thanks for the fix, jow :-)

comment:16 Changed 6 years ago by pierre.gaufillet@…

It also works on wndr3700 (ar71xx, Linux 2.39.x): great!

comment:17 Changed 6 years ago by jow

  • Resolution set to fixed
  • Status changed from accepted to closed

Very well, I mark this one as fixed then. Thank you for taking the time to test it.

comment:18 Changed 5 years ago by anonymous

Hello, could you please explain how to fix it ? If the module need to be compiled could you explain how ? Regards,

comment:19 Changed 5 years ago by Fabroce

Fixed on trunk, just select module "kmod-ipt-nathelper-rtsp"

comment:20 Changed 5 years ago by anonymous

Ok thx.

It is possible to use trunk version of kmod-ipt-nathelper-rtsp ? (I'm using version 10.03.1 of backfire and not the trunk version).

Regards,

comment:21 Changed 5 years ago by Fabroce

No, kernel version has been updated on trunk, the patch may not compile on 10.03.1 .
You will have to checkout 10.03.1 source tree, delete the original patch (target/linux/generic-2.6/patches-2.6.32/190-netfilter_rtsp.patch) and replace it with 190-netfilter_rtsp.2.patch posted above.
I didn't test it but it should work.

comment:22 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.