Modify

Opened 12 years ago

Closed 12 years ago

#515 closed defect (fixed)

[nas] S41wpa doesn't kill nas

Reported by: Mark Mentovai <mark at moxienet dot com> Owned by: florian
Priority: normal Milestone: 0.9/rc6
Component: packages Version:
Keywords: Cc:

Description

/etc/init.d/S41wpa, line 20 (nas 3.90.37-16 on 1rc5):

19        echo /usr/sbin/nas $@ > /var/run/nas.lan.conf
20        killall -w nas 2> /dev/null > /dev/null
21        /usr/sbin/nas "$@" &

killall does not understand this -w argument, and neither do I:

root@gw1:~# killall -w nas
killall: bad signal name 'w'
root@gw1:~# pidof nas
391

If I had to guess, I'd say that the -w is a typo and was supposed to be -q, due to the two keys' proximity on the abortion of a layout that we call QWERTY.

Might I also suggest that lines 19 and 20 be reversed? The code flows better like this:

19        killall -q nas 2> /dev/null > /dev/null
20        echo /usr/sbin/nas $@ > /var/run/nas.lan.conf
21        /usr/sbin/nas "$@" &

Attachments (0)

Change History (2)

comment:1 Changed 12 years ago by florian

  • Milestone set to 1.0-rc6
  • Owner changed from developers to florian
  • Status changed from new to assigned

comment:2 Changed 12 years ago by florian

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with latest rsync

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.