Modify

Opened 10 years ago

Closed 10 years ago

#2976 closed enhancement (wontfix)

fix usb.mk typo

Reported by: michu-at-neophobdotcom Owned by: developers
Priority: normal Milestone:
Component: packages Version:
Keywords: Cc:

Description

There is a typo in the usb.mk file.

Index: package/kernel/modules/usb.mk
===================================================================
--- package/kernel/modules/usb.mk       (revision 10117)
+++ package/kernel/modules/usb.mk       (working copy)
@@ -18,9 +18,9 @@
   USBINPUT_DIR:=usb/input
 endif

-USBNET_DIR?=net/usb
-USBHID_DIR?=hid/usbhid
-USBINPUT_DIR?=input/misc
+USBNET_DIR:=net/usb
+USBHID_DIR:=hid/usbhid
+USBINPUT_DIR:=input/misc

those error messages gets displayed:

WARNING: kmod-usb-net-asix is not available in the kernel config
WARNING: kmod-usb-net-kaweth is not available in the kernel config
WARNING: kmod-usb-net-pegasus is not available in the kernel config
WARNING: kmod-usb-hid is not available in the kernel config
WARNING: kmod-usb-yealink is not available in the kernel config
WARNING: kmod-usb-atm-speedtouch is not available in the kernel config
WARNING: kmod-usb-atm-ueagle is not available in the kernel config
WARNING: kmod-usb-video is not available in the kernel config
WARNING: kmod-usb-serial-sierrawireless is not available in the kernel config
WARNING: kmod-usb-serial-visor is not available in the kernel config
WARNING: kmod-usb-serial-keyspan is not available in the kernel config
WARNING: kmod-usb-serial-option is not available in the kernel config

Attachments (1)

usb-mk.patch (2.1 KB) - added by michu-at-neophob-com 10 years ago.
fix type, add support for usb-hid

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by michu-at-neophob-com

but there is still an error to compile those modules:

WARNING: kmod-usb-video is not available in the kernel config
WARNING: kmod-usb-hid is not available in the kernel config

comment:2 Changed 10 years ago by michu-at-neophob-com

the usb-hid error may be related to #2184

comment:3 Changed 10 years ago by anonymous

I guess the default definition of USB*_DIR should the at the first position, so it works also with kernel 2.4 and kernel 2.6.21, updated patch:

Index: package/kernel/modules/usb.mk
===================================================================
--- package/kernel/modules/usb.mk       (revision 10117)
+++ package/kernel/modules/usb.mk       (working copy)
@@ -8,6 +8,10 @@

 USB_MENU:=USB Support

+USBNET_DIR:=net/usb
+USBHID_DIR:=hid/usbhid
+USBINPUT_DIR:=input/misc
+
 ifeq ($(KERNEL),2.4)
   USBNET_DIR:=usb/net
 endif
@@ -18,10 +22,6 @@
   USBINPUT_DIR:=usb/input
 endif

-USBNET_DIR?=net/usb
-USBHID_DIR?=hid/usbhid
-USBINPUT_DIR?=input/misc

Changed 10 years ago by michu-at-neophob-com

fix type, add support for usb-hid

comment:4 Changed 10 years ago by michu-at-neophob-com

the patch is not perfect, when i try to rebuild the option "(HID_SUPPORT) [Y/n/?] (NEW)" needs to answered manually... I dont really know how to fix this. anyway:

michux@fwpiercer:/home/openwrt/trunk/bin/packages$ ls kmod-usb-hid* -al
-rw-r--r-- 1 michux michux 36123 2008-01-05 21:45 kmod-usb-hid_2.6.23.1-brcm47xx-1_mipsel.ipk

comment:5 Changed 10 years ago by florian

  • Resolution set to invalid
  • Status changed from new to closed

The thing you are trying to fix is not an error, we use valid gnu make syntax.

comment:6 Changed 10 years ago by michu-at-neophobdotcom

  • Resolution invalid deleted
  • Status changed from closed to reopened

i agree about the syntax, but for example kmod-usb-hid* gets not build, i guess this is because of missing kernel options (CONFIG_HID...)

comment:7 Changed 10 years ago by anonymous

why patch not joined ??

comment:8 Changed 10 years ago by florian

  • Resolution set to wontfix
  • Status changed from reopened to closed

The patch is useles, if any of the 3 definitions is empty, it will pick the one that is proposed with the ? symbol.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.