Modify

Opened 10 years ago

Closed 9 years ago

#2463 closed defect (fixed)

20-broadcom_wds Script has deffeciencies

Reported by: anonymous Owned by: florian
Priority: normal Milestone: Kamikaze 7.09
Component: base system Version:
Keywords: Cc:

Description

In /etc/hotplug.d/net/20-broadcom_wds

CHANGE one line of as4not to:

.

.
.

sleep 5

case "$encryption" in

psk|PSK)

nas4not "$network" "$iface" up auto tkip psk "$key" "$ssid"

;;
psk2|PSK2)

nas4not "$network" "$iface" up auto aes psk "$key" "$ssid"

;;
psk+psk2|psk2+psk|PSK+PSK2|PSK2+PSK)

nas4not "$network" "$iface" up auto aes+tkip psk "$key" "$ssid"

;;
*)
;;

esac
.
.
.

WDS with WPA1 will now be supported again, which is necessary for broadcom chipsets

Attachments (1)

20-broadcom_wds.patch (2.9 KB) - added by cowboy+openwrt@… 10 years ago.
patch to fix/close #2548 and #2463

Download all attachments as: .zip

Change History (10)

comment:1 in reply to: ↑ description Changed 10 years ago by anonymous

Replying to anonymous:

In /etc/hotplug.d/net/20-broadcom_wds

CHANGE one line of as4not to:

.

.
.

sleep 5

case "$encryption" in

psk|PSK)

nas4not "$network" "$iface" up auto tkip psk "$key" "$ssid"

;;
psk2|PSK2)

nas4not "$network" "$iface" up auto aes psk "$key" "$ssid"

;;
psk+psk2|psk2+psk|PSK+PSK2|PSK2+PSK)

nas4not "$network" "$iface" up auto aes+tkip psk "$key" "$ssid"

;;
*)
;;

esac
.
.
.

WDS with WPA1 will now be supported again, which is necessary for broadcom chipsets

comment:2 in reply to: ↑ description Changed 10 years ago by anonymous

Replying to anonymous:

In /etc/hotplug.d/net/20-broadcom_wds

CHANGE one line of as4not to:
[snip]
WDS with WPA1 will now be supported again, which is necessary for broadcom chipsets

I am very interested in this patch, and hate to carry around (and constantly revalidate a plethora of local patches)... Are there concerns with this approach? I certainly looks better than what is currently done.

Would a proper patch speed things? what patch options do you prefer?

comment:3 Changed 10 years ago by florian

Yes, please attach a patch as an attachment.

Changed 10 years ago by cowboy+openwrt@…

patch to fix/close #2548 and #2463

comment:4 Changed 10 years ago by cowboy

Patch done by nlh on 2007-06-21

comment:5 Changed 10 years ago by cowboy

sorry for the delay, life kinda got in the way

comment:6 Changed 10 years ago by cowboy

Any news on this issue ? Is the patch unusable ?
--
Rick

comment:7 Changed 9 years ago by florian

  • Owner changed from developers to florian
  • Status changed from new to assigned

Please resubmit your patch using svn diff against the modified file. I think it was generated inverted.

comment:8 Changed 9 years ago by florian

Does the following patch with sleep 1 instead of sleep 5 works for you guys ? :

Index: package/broadcom-wl/files/etc/hotplug.d/net/20-broadcom_wds
===================================================================
--- package/broadcom-wl/files/etc/hotplug.d/net/20-broadcom_wds (revision 12151)
+++ package/broadcom-wl/files/etc/hotplug.d/net/20-broadcom_wds (working copy)
@@ -31,7 +31,20 @@

                        [ "$encryption" != "none" ] && {
                                sleep 1
-                               nas4not lan "$iface" up auto aes "$encryption" "$key" "$ssid"
+                               case "$encryption" in
+                                       psk|PSK)
+                                               nas4not "$network" "$iface" up auto tkip psk "$key" "$ssid"
+                                               ;;
+                                       psk2|PSK2)
+                                               nas4not "$network" "$iface" up auto aes psk "$key" "$ssid"
+                                               ;;
+                                       psk+psk2|psk2+psk|PSK+PSK2|PSK2+PSK)
+                                               nas4not "$network" "$iface" up auto aes+tkip psk "$key" "$ssid"
+                                               ;;
+                                       *)
+                                               nas4not lan "$iface" up auto aes "$encryption" "$key" "$ssid"
+                                               ;;
+                                       esac
                        }
                }
        }

comment:9 Changed 9 years ago by florian

  • Resolution set to fixed
  • Status changed from assigned to closed

Applied in [12251].

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.