Modify

Opened 22 months ago

Last modified 21 months ago

#22210 new defect

mt7620 patch contains invalid values

Reported by: anonymous Owned by: developers
Priority: high Milestone: Designated Driver (Trunk)
Component: kernel Version: Trunk
Keywords: Cc:

Description

part of 910-01-add-support-for-mt7620.patch with many incorrect default register values

+		if (rt2x00dev->chip.rf == RF7620) {
+			rt2800_register_write(rt2x00dev, TX_SW_CFG0,
+							0x00000401);
+			rt2800_register_write(rt2x00dev, TX_SW_CFG1,
+							0x000C0000);
+			rt2800_register_write(rt2x00dev, TX_SW_CFG2,
+							0x00000000);
+			rt2800_register_write(rt2x00dev, MIMO_PS_CFG,
+							0x00000002);
+			rt2800_register_write(rt2x00dev, TX_PIN_CFG,
+							0x00150F0F);
+			rt2800_register_write(rt2x00dev, TX_ALC_VGA3,
+							0x06060606);
+			rt2800_register_write(rt2x00dev, TX0_BB_GAIN_ATTEN,
+							0x0);
+			rt2800_register_write(rt2x00dev, TX1_BB_GAIN_ATTEN,
+							0x0);
+			rt2800_register_write(rt2x00dev, TX0_RF_GAIN_ATTEN,
+							0x6C6C666C);
+			rt2800_register_write(rt2x00dev, TX1_RF_GAIN_ATTEN,
+							0x6C6C666C);
+			rt2800_register_write(rt2x00dev, TX0_RF_GAIN_CORRECT,
+							0x3630363A);
+			rt2800_register_write(rt2x00dev, TX1_RF_GAIN_CORRECT,
+							0x3630363A);
+			rt2800_register_read(rt2x00dev, TX_ALG_CFG_1, &reg);
+			reg = reg & (~0x80000000);
+			rt2800_register_write(rt2x00dev, TX_ALG_CFG_1, reg);

TX0_RF_GAIN_ATTEN and TX1_RF_GAIN_ATTEN should have 0x6C6C6C6C

TX0_RF_GAIN_CORRECT and TX1_RF_GAIN_CORRECT should have 0x0

TX0_BB_GAIN_ATTEN and TX1_BB_GAIN_ATTEN should have 0x18181818

MIMO_PS_CFG should have 0x00000004

TX_PIN_CFG,TX_SW_CFG0,TX_SW_CFG1,TX_SW_CFG2 where do these values come from, especially for TX_PIN_CFG ?? because programming guide has no defaults for those registers.

TX_ALG_CFG_1 is misspelled TX_ALC_CFG_1, there is no TX_ALC_CFG_0

Attachments (0)

Change History (8)

comment:1 Changed 22 months ago by fclql

Wireless often dropped

comment:2 Changed 22 months ago by anonymous

http://s9.postimg.org/a3bnvy8kf/Screenshot.png

comment:3 follow-up: Changed 22 months ago by 123serge123

Values in patch corresponds current vendor driver source.

comment:4 Changed 22 months ago by anonymous

the changes may have an impact on other mt7620a devices like xiaomi mini who have bad receive.

comment:5 Changed 22 months ago by gazambuja

some one try this values?
How I can test for you guys?

comment:6 in reply to: ↑ 3 Changed 22 months ago by changeway

Replying to 123serge123:

Values in patch corresponds current vendor driver source.

May refer this code session of mediatek mt7620 driver
https://github.com/changeway/mtk-sources/blob/master/mt7620/src/chips/rt6352.c#L721

comment:7 Changed 22 months ago by anonymous

do you know 2.4G wifi had the strongest signal with openwrt fw? all other eg. panodrabox,padavan,changeway,xiaomi etc. were showing less strong tx signal.

comment:8 Changed 21 months ago by anonymous

What are the chances of us getting this included in Trunk some time soon?

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.