Modify

Opened 11 years ago

Closed 8 years ago

Last modified 4 years ago

#2153 closed enhancement (fixed)

adm5120: make switch port leds work

Reported by: berny156 at gmx.de Owned by: juhosg
Priority: normal Milestone: Barrier Breaker 14.07
Component: kernel Version:
Keywords: adm5120 trigger port led Cc:

Description

The attached patch adds another trigger for the adm5120 switch port leds. This finally makes the lan port leds on my BR-6104K work as expected.

Activate trigger (automagically selected on BR-6104K):
echo port_led > /sys/class/leds/$port/trigger

Select state (again not needed on BR-6104K, because this router uses the hardware default):
echo link_act > /sys/class/leds/$port/port_state

This is my first linux driver, so please feel free to fix/adjust/modify any oddity.

The 2nd file should not be commited. It's just an example for edimax BR-6104K* users. It shows a fancy usage of the power led. It flashes, as long as the init-system is not ready.

Attachments (5)

adm5120_switch_port_led.patch (7.4 KB) - added by berny156 AT gmx.de 11 years ago.
add led trigger for adm5120 switch port leds
diag.sh.patch (629 bytes) - added by berny156 AT gmx.de 11 years ago.
add diag.sh to control the power led on BR-6104K
adm5120_switch_port_led_v2.patch (9.2 KB) - added by anonymous 11 years ago.
add led trigger for adm5120 switch port leds; forgot to add one diff
adm5120_switch_port_led_r8391.patch (6.9 KB) - added by berny156 AT gmx.de 10 years ago.
adopted changes from r8351
adm5120_switch_led_trigger.patch (6.1 KB) - added by juhosg 10 years ago.

Download all attachments as: .zip

Change History (13)

Changed 11 years ago by berny156 AT gmx.de

add led trigger for adm5120 switch port leds

Changed 11 years ago by berny156 AT gmx.de

add diag.sh to control the power led on BR-6104K

comment:1 Changed 11 years ago by juhosg

  • Owner changed from developers to juhosg
  • Status changed from new to assigned

Changed 11 years ago by anonymous

add led trigger for adm5120 switch port leds; forgot to add one diff

Changed 10 years ago by berny156 AT gmx.de

adopted changes from r8351

Changed 10 years ago by juhosg

comment:2 Changed 10 years ago by juhosg

  • Milestone set to Kamikaze

I have simplified it a bit. Can you test it?

comment:3 Changed 10 years ago by berny156 AT gmx.de

Works great! Thanks for the review.

Bernhard

comment:4 Changed 10 years ago by juhosg

  • Resolution set to fixed
  • Status changed from assigned to closed

Added in [9362], thanks.

comment:5 Changed 10 years ago by anonymous

  • Resolution fixed deleted
  • Status changed from closed to reopened

The port state trigger seems to work, but is not automagically aktivated for any switchport on the br6104kp profile, dont know if this works on br6104k.

comment:6 Changed 9 years ago by anonymous

searching how to enable switch leds brought me here. nowadays you have to echo port_state > /sys/class/leds/$port/trigger ,just as described here: http://forum.openwrt.org/viewtopic.php?id=13767 ( tested with kamikaze revision 12834)

comment:7 Changed 8 years ago by florian

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:8 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.