Modify

Opened 11 years ago

Closed 10 years ago

Last modified 4 years ago

#2139 closed enhancement (wontfix)

Allows redboot to consumes kernel command line parameters

Reported by: fabsoft Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: kernel Version:
Keywords: kernel command line parameters Cc:

Description

Allows redboot to consumes kernel command line parameters, fix from #8049 that doesn't allow params overwriting.
Note that this patch will overwrite CONFIG_CMDLINE default. hence whereas redboot provides a parameter, this one should contains vitals params also. (eg:
on fonera, redboot param should be at least: rootfstype=squashfs,jffs2 init=/etc/preinit, .... )

Attachments (1)

100-atheros-redboot-cmdline.diff (518 bytes) - added by anonymous 11 years ago.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by anonymous

comment:1 follow-up: Changed 11 years ago by jhansen@…

It would probably be better to prepend the RedBoot command line to the compiled-in command line instead of overwriting it. That should allow you to make changes to the compiled-in command line without having to unnecessarily define most of the compiled-in command line.

comment:2 in reply to: ↑ 1 Changed 11 years ago by anonymous

Replying to jhansen@cardaccess-inc.com:

It would probably be better to prepend the RedBoot command line to the compiled-in command line instead of overwriting it. That should allow you to make changes to the compiled-in command line without having to unnecessarily define most of the compiled-in command line.

without parameters overwriting it is impossible to remove switches.
in my case i got disabled serial port by removing "console=ttyS0,9600".
i dont know how to solve my problem using your advise.

comment:3 follow-up: Changed 11 years ago by jhansen@…

I created this patch in this way because that is exactly how all of the other mips architectures are dealing with the bootloader-supplied command line -- by appending to the end of the compile-time one.

I think the best bet is to erase your compile-time command line, since this method of appending is the way all other arch's do it.

comment:4 in reply to: ↑ 3 Changed 11 years ago by fabsoft

Replying to jhansen@cardaccess-inc.com:

I created this patch in this way because that is exactly how all of the other mips architectures are dealing with the bootloader-supplied command line -- by appending to the end of the compile-time one.

I think the best bet is to erase your compile-time command line, since this method of appending is the way all other arch's do it.

im my opinion my patch is able to append and remove parameters both.
i only think this way is better

comment:5 Changed 10 years ago by florian

  • Resolution set to wontfix
  • Status changed from new to closed

It appeared that the previous patch was causing some foneras not to boot. So we won't touch the kernel command line at all.

comment:6 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.