Modify

Opened 2 years ago

Closed 2 years ago

#21362 closed defect (fixed)

ar71xx broken due to mr18 (introduced by r47878)

Reported by: hnyman Owned by: developers
Priority: high Milestone: Designated Driver (Trunk)
Component: base system Version: Trunk
Keywords: ar71xx mr18 Cc: hannu.nyman@…

Description

ar71xx compilation is broken. Seems to be due to mr18 added by r47878:

  CHK     include/generated/compile.h
  CC      arch/mips/ath79/mach-mr18.o
arch/mips/ath79/mach-mr18.c: In function 'mr18_setup':
arch/mips/ath79/mach-mr18.c:257:10: error: 'QCA955X_ETH_CFG_RXD_DELAY_SHIFT' undeclared (first use in this function)
    (3 << QCA955X_ETH_CFG_RXD_DELAY_SHIFT) |
          ^
arch/mips/ath79/mach-mr18.c:257:10: note: each undeclared identifier is reported only once for each function it appears in
arch/mips/ath79/mach-mr18.c:258:10: error: 'QCA955X_ETH_CFG_RDV_DELAY_SHIFT' undeclared (first use in this function)
    (3 << QCA955X_ETH_CFG_RDV_DELAY_SHIFT));
          ^
scripts/Makefile.build:258: recipe for target 'arch/mips/ath79/mach-mr18.o' failed
make[7]: *** [arch/mips/ath79/mach-mr18.o] Error 1
scripts/Makefile.build:403: recipe for target 'arch/mips/ath79' failed
make[6]: *** [arch/mips/ath79] Error 2

I think that the mr18 code already committed in r47878 depends on a patch still in the patch queue:
https://patchwork.ozlabs.org/patch/555846/
"ar71xx: add rx/tx delay definitons for qca955x's MAC"

Attachments (0)

Change History (2)

comment:1 Changed 2 years ago by hnyman

I tested and got things fixed in two different ways:

Looks like the patch applied in r47878 was re-issued ( https://patchwork.ozlabs.org/patch/555927/ ) separately from then earlier patch series, and was applied without the supporting items included in the patch series.

comment:2 Changed 2 years ago by nbd

  • Resolution set to fixed
  • Status changed from new to closed

fixed in r47882

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.