Modify

Opened 2 years ago

Closed 20 months ago

Last modified 19 months ago

#21350 closed defect (wontfix)

rp-pppoe compilation failed

Reported by: fclql Owned by: developers
Priority: normal Milestone:
Component: packages Version: Trunk
Keywords: Cc: musl

Description

In file included from pppoe.h:143:0,
                 from pppoe.c:19:
/home/openwrt/staging_dir/toolchain-mipsel_24kec+dsp_gcc-5.2.0_musl-1.1.11/include/netinet/if_ether.h:96:8: error: redefinition of 'struct ethhdr'
 struct ethhdr {
        ^
In file included from pppoe.h:131:0,
                 from pppoe.c:19:
/home/openwrt/staging_dir/toolchain-mipsel_24kec+dsp_gcc-5.2.0_musl-1.1.11/include/linux/if_ether.h:139:8: note: originally defined here
 struct ethhdr {
        ^
make[3]: *** [pppoe.o] Error 1

Attachments (2)

Makefile (3.9 KB) - added by hojuruku 20 months ago.
feeds/oldpackages/net/rp-pppoe/Makefile PKG_RELEASE:=2
120-musl11-configure.patch (331 bytes) - added by hojuruku 20 months ago.
feeds/oldpackages/net/rp-pppoe/patches/120-musl11-configure.patch

Download all attachments as: .zip

Change History (12)

comment:1 Changed 2 years ago by anonymous

Seriously? You bugreport does not contain a single line of useful information. I can not even get, which package fails to build.

  • which branch and revision?
  • target device?
  • build log!

comment:2 Changed 2 years ago by nbd

  • Resolution set to wontfix
  • Status changed from new to closed

rp-pppoe is unmaintained, no changes will be made until it is cleaned up and submitted to the github repo.

comment:3 Changed 20 months ago by hojuruku

https://github.com/openwrt/packages/pull/1387

Yeah but it's not hard to fix in other apps. nbd pretty please with sugar on top import this. I'm hacking a vietnamese router so the viet ppl can have pppoe wan parties (due to a a weakness in a telco here)

Luke

comment:4 Changed 20 months ago by hojuruku

  • Resolution wontfix deleted
  • Status changed from closed to reopened

I've got a patch for this - testing now. Even though it's unmaintained you can submit it to git nbd.

Changed 20 months ago by hojuruku

feeds/oldpackages/net/rp-pppoe/Makefile PKG_RELEASE:=2

Changed 20 months ago by hojuruku

feeds/oldpackages/net/rp-pppoe/patches/120-musl11-configure.patch

comment:5 Changed 20 months ago by jogo

  • Resolution set to wontfix
  • Status changed from reopened to closed

If you want to have rp-pppoe available in future releases, please take over maintainership and create a pull request with an updated and fixed version at https://github.com/openwrt/packages.

The old packages feed is a read/delete-only repository, and won't get any new fixes/updates added.

comment:6 Changed 20 months ago by hojuruku

jogo:

/ticket/22661.html
#22661 is a dependency to make this and other packages compile. I'm just working on v2 of the patch, when everything is tested I'll submit it to openwrt-dev. That's kernel / pppd patches so it has to go through nbd for sign off.

I volunteer maintain rp-pppoe because I plan to have great fun with it due to lax ISP security in X country to have pppoe lan parties in the same POP.

So I'll re-open the ticket. Give me a few days to do the pull request OK.
I am github.com/hojuruku

comment:7 Changed 20 months ago by hojuruku

  • Resolution wontfix deleted
  • Status changed from closed to reopened

comment:8 Changed 20 months ago by jogo

  • Resolution set to wontfix
  • Status changed from reopened to closed

Don't reopen the ticket; just open a pull request on github. The one in OpenWrt's (old) packages feed will remain unfixed.

comment:9 Changed 20 months ago by hojuruku

https://github.com/openwrt/openwrt/pull/15

"I gave up trying to patch the source to update the include/linux & include/net headers for now
My patch broke pppd plugins. net/ppp_defs.h is needed to build any project that includes pppd.h"

Don't use the patch files here, they don't work. I might have another crack at it later if necessary to build rp-pppoe.
That Makefile patch will install the bundled pppd bundled net/ppp_defs.h into the staging_dir

comment:10 Changed 19 months ago by anonymous

For the benefit of others who opened this ticket.

FYI I am *trying to* push the package back into openwrt.
https://github.com/openwrt/packages/pull/2974

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.