Modify

Opened 11 years ago

Closed 11 years ago

Last modified 4 years ago

#2122 closed defect (fixed)

invalid characters in changes of r8107

Reported by: MMCM <mmcm@…> Owned by: nico
Priority: highest Milestone: Barrier Breaker 14.07
Component: base system Version:
Keywords: Cc:

Description

@# FIXME: removing this line will cause the foreach loop below to execute the next statement only on the first iteration, don't ask why ;)

don't use single quotes or a ")" otherwise make will display errors of unmatched single quotes, ...

Additionally, I have to insert a blank line before this one, otherwise it will be appended to /trunk/staging_dir_mipsel/bin/trx2usr as an additional argument.

Attachments (0)

Change History (4)

comment:1 Changed 11 years ago by nico

  • Owner changed from developers to nico
  • Status changed from new to assigned

Inserting a blank line cause make errors on my build system (Ubuntu Dapper), does removing the @ and the offending comments solve the problem on yours?

comment:2 Changed 11 years ago by MMCM <mmcm@…>

If I remove the blank line and the one with @, it does not work:

/srv/devel/openwrt-2.6.22/trunk/staging_dir_mipsel/bin/addpattern -4 -p EWCB -v v0.93.10 -i /srv/devel/openwrt-2.6.22/trunk/bin/openwrt-brcm47xx-2.6-jffs2-64k.trx -o /srv/devel/openwrt-2.6.22/trunk/bin/openwrt-wrt300n_v1-2.6-jffs2.bin
mjn3's addpattern replacement - v0.81
writing firmware v0.93.10 on 7/7/23 (y/m/d)
/srv/devel/openwrt-2.6.22/trunk/staging_dir_mipsel/bin/motorola-bin -2 /srv/devel/openwrt-2.6.22/trunk/bin/openwrt-brcm47xx-2.6-jffs2-64k.trx /srv/devel/openwrt-2.6.22/trunk/bin/openwrt-wa840g-jffs2.bin
/srv/devel/openwrt-2.6.22/trunk/staging_dir_mipsel/bin/motorola-bin -3 /srv/devel/openwrt-2.6.22/trunk/bin/openwrt-brcm47xx-2.6-jffs2-64k.trx /srv/devel/openwrt-2.6.22/trunk/bin/openwrt-we800g-jffs2.bin
/srv/devel/openwrt-2.6.22/trunk/staging_dir_mipsel/bin/motorola-bin -1 /srv/devel/openwrt-2.6.22/trunk/bin/openwrt-brcm47xx-2.6-jffs2-64k.trx /srv/devel/openwrt-2.6.22/trunk/bin/openwrt-wr850g-jffs2-64k.bin
/srv/devel/openwrt-2.6.22/trunk/staging_dir_mipsel/bin/trx2usr /srv/devel/openwrt-2.6.22/trunk/bin/openwrt-brcm47xx-2.6-jffs2-64k.trx /srv/devel/openwrt-2.6.22/trunk/bin/openwrt-usr5461-jffs2-64k.bin               /srv/devel/openwrt-2.6.22/trunk/staging_dir_mipsel/bin/mkfs.jffs2 --pad --little-endian --squash -e 128KiB -o /srv/devel/openwrt-2.6.22/trunk/build_mipsel/linux-2.6-brcm47xx/root.jffs2-128k -d /srv/devel/openwrt-2.6.22/trunk/build_mipsel/root
Usage: trx2usr <trx input> <usr output>
make[3]: *** [install] Error 2
make[3]: Leaving directory `/srv/devel/openwrt-2.6.22/trunk/target/linux/brcm-2.4/image'
make[2]: *** [image_install] Error 2
make[2]: Leaving directory `/srv/devel/openwrt-2.6.22/trunk/target'
make[1]: *** [target/install] Error 2
make[1]: Leaving directory `/srv/devel/openwrt-2.6.22/trunk'
make: *** [world] Fehler 2

with the blank line alone, without @, it's still working:

/srv/devel/openwrt-2.6.22-rc5/trunk/staging_dir_mipsel/bin/addpattern -4 -p EWCB -v v0.93.10 -i /srv/devel/openwrt-2.6.22-rc5/trunk/bin/openwrt-brcm47xx-2.6-jffs2-64k.trx -o /srv/devel/openwrt-2.6.22-rc5/trunk/bin/openwrt-wrt300n_v1-2.6-jffs2.bin
mjn3's addpattern replacement - v0.81
writing firmware v0.93.10 on 7/7/23 (y/m/d)
/srv/devel/openwrt-2.6.22-rc5/trunk/staging_dir_mipsel/bin/motorola-bin -2 /srv/devel/openwrt-2.6.22-rc5/trunk/bin/openwrt-brcm47xx-2.6-jffs2-64k.trx /srv/devel/openwrt-2.6.22-rc5/trunk/bin/openwrt-wa840g-jffs2.bin
/srv/devel/openwrt-2.6.22-rc5/trunk/staging_dir_mipsel/bin/motorola-bin -3 /srv/devel/openwrt-2.6.22-rc5/trunk/bin/openwrt-brcm47xx-2.6-jffs2-64k.trx /srv/devel/openwrt-2.6.22-rc5/trunk/bin/openwrt-we800g-jffs2.bin
/srv/devel/openwrt-2.6.22-rc5/trunk/staging_dir_mipsel/bin/motorola-bin -1 /srv/devel/openwrt-2.6.22-rc5/trunk/bin/openwrt-brcm47xx-2.6-jffs2-64k.trx /srv/devel/openwrt-2.6.22-rc5/trunk/bin/openwrt-wr850g-jffs2-64k.bin
/srv/devel/openwrt-2.6.22-rc5/trunk/staging_dir_mipsel/bin/trx2usr /srv/devel/openwrt-2.6.22-rc5/trunk/bin/openwrt-brcm47xx-2.6-jffs2-64k.trx /srv/devel/openwrt-2.6.22-rc5/trunk/bin/openwrt-usr5461-jffs2-64k.bin
/srv/devel/openwrt-2.6.22-rc5/trunk/staging_dir_mipsel/bin/mkfs.jffs2 --pad --little-endian --squash -e 128KiB -o /srv/devel/openwrt-2.6.22-rc5/trunk/build_mipsel/linux-2.6-brcm47xx/root.jffs2-128k -d /srv/devel/openwrt-2.6.22-rc5/trunk/build_mipsel/root
echo -ne '\xde\xad\xc0\xde' >> /srv/devel/openwrt-2.6.22-rc5/trunk/build_mipsel/linux-2.6-brcm47xx/root.jffs2-128k
/srv/devel/openwrt-2.6.22-rc5/trunk/staging_dir_mipsel/bin/trx -o /srv/devel/openwrt-2.6.22-rc5/trunk/bin/openwrt-brcm47xx-2.6-jffs2-128k.trx -f /srv/devel/openwrt-2.6.22-rc5/trunk/build_mipsel/linux-2.6-brcm47xx/loader.gz -f /srv/devel/openwrt-2.6.22-rc5/trunk/build_mipsel/linux-2.6-brcm47xx/vmlinux.lzma -a 0x20000 -f /srv/devel/openwrt-2.6.22-rc5/trunk/build_mipsel/linux-2.6-brcm47xx/root.jffs2-128k
mjn3's trx replacement - v0.81.1

For some days, I have to run make with FORCE=1, because I get the following error, no other message:

> make
Prerequisite check failed. Use FORCE=1 to override.
make: *** [tmp/.prereq-package] Fehler 1

I cannot see what's wrong/missing on my system (opensuse 10.2)...

comment:3 Changed 11 years ago by nico

  • Resolution set to fixed
  • Status changed from assigned to closed

Should be fixed in [8166]

comment:4 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.