Modify

Opened 12 years ago

Closed 12 years ago

#212 closed defect (invalid)

no need for setserial to create /etc/init.d/S15serial

Reported by: wtzm Owned by: developers
Priority: normal Milestone:
Component: base system Version:
Keywords: Cc:

Description

The setserial call in S15serial is not necessary to correctly set the irq for the second serial port. (tested on wl-500g deluxe, svn r2917)
Two lines in the setserial Makefile and the setserial/files folder which contains the S15serial file, can be removed.

Index: package/setserial/Makefile
===================================================================
--- package/setserial/Makefile	(revision 2986)
+++ package/setserial/Makefile	(working copy)
@@ -50,8 +50,6 @@
 	touch $@
 
 $(IPKG_SETSERIAL):
-	install -d -m0755 $(IDIR_SETSERIAL)/etc/init.d
-	install -m0755 ./files/serial.init $(IDIR_SETSERIAL)/etc/init.d/S15serial
 	install -d -m0755 $(IDIR_SETSERIAL)/usr/sbin
 	install -m0755 $(PKG_BUILD_DIR)/setserial $(IDIR_SETSERIAL)/usr/sbin/
 	$(RSTRIP) $(IDIR_SETSERIAL)

Attachments (0)

Change History (1)

comment:1 Changed 12 years ago by nbd

  • Resolution set to invalid
  • Status changed from new to closed

Some devices still need it (at least some WRT54G revs)

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.