Modify

Opened 2 years ago

Last modified 2 years ago

#20679 new defect

Build fails: symbol undeclared in ifxusb_cif_h.c (ltq-hcd)

Reported by: juanriccio@… Owned by: developers
Priority: normal Milestone:
Component: packages Version: Trunk
Keywords: Cc:

Description

Here's a piece of the log

make[3]: Entering directory `/openwrt/trunk/package/kernel/lantiq/ltq-hcd'
cd /openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/linux-4.1.10; ARCH=mips CROSS_COMPILE="mips-openwrt-linux-musl-" make BUILD_VARIANT=ar9 M=/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9 V=1 modules
make[4]: Entering directory `/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/linux-4.1.10'

test -e include/generated/autoconf.h -a -e include/config/auto.conf
( \

echo >&2; \
echo >&2 " ERROR: Kernel configuration is invalid."; \
echo >&2 " include/generated/autoconf.h or include/config/auto.conf are missing.";\
echo >&2 " Run 'make oldconfig && make prepare' on kernel src to fix it."; \
echo >&2 ; \
/bin/false)

mkdir -p /openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/.tmp_versions ; rm -f /openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/.tmp_versions/*
make -f ./scripts/Makefile.build obj=/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9

mips-openwrt-linux-musl-gcc -Wp,-MD,/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/.ifxusb_cif_h.o.d -nostdinc -isystem /openwrt/trunk/staging_dir/toolchain-mips_34kc+dsp_gcc-4.8-linaro_musl-1.1.11/lib/gcc/mips-openwrt-linux-musl/4.8.3/include -I./arch/mips/include -Iarch/mips/include/generated/uapi -Iarch/mips/include/generated -Iinclude -I./arch/mips/include/uapi -Iarch/mips/include/generated/uapi -I./include/uapi -Iinclude/generated/uapi -include ./include/linux/kconfig.h -DKERNEL -DVMLINUX_LOAD_ADDRESS=0xffffffff80002000 -DDATAOFFSET=0 -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -std=gnu89 -mno-check-zero-division -mabi=32 -G 0 -mno-abicalls -fno-pic -pipe -mno-branch-likely -msoft-float -DGAS_HAS_SET_HARDFLOAT -Wa,-msoft-float -ffreestanding -march=mips32r2 -Wa,-mips32r2 -Wa,--trap -I./arch/mips/include/asm/mach-lantiq -I./arch/mips/include/asm/mach-lantiq/xway -I./arch/mips/include/asm/mach-generic -fno-delete-null-pointer-checks -O2 -fno-reorder-blocks -fno-tree-ch -fno-caller-saves --param=allow-store-data-races=0 -Wframe-larger-than=1024 -fno-stack-protector -Wno-unused-but-set-variable -fomit-frame-pointer -fno-var-tracking-assignments -g -femit-struct-debug-baseonly -fno-var-tracking -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fconserve-stack -Werror=implicit-int -Werror=strict-prototypes -DCC_HAVE_ASM_GOTO -DIS_AR9 -DIS_DUAL -DUNALIGNED_BUF_ADJ -Dlinux -DLINUX -DIS_HOST -DKERNEL -DDYN_SOF_INTR -DUEIP -DDO_OC_INT -DINNAKSTOP_BULK -DINTRNAKRETRY -DINTRINCRETRY -DMODULE -mno-long-calls -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(ifxusb_cif_h)" -D"KBUILD_MODNAME=KBUILD_STR(ltq_hcd_ar9)" -c -o /openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/ifxusb_cif_h.o /openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/ifxusb_cif_h.c

/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/ifxusb_cif_h.c: In function 'ifxusb_oc_int_on':
/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/ifxusb_cif_h.c:1177:11: error: 'IRQF_DISABLED' undeclared (first use in this function)

| IRQF_DISABLED


/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/ifxusb_cif_h.c:1177:11: note: each undeclared identifier is reported only once for each function it appears in
make[5]: * /openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/ifxusb_cif_h.o Error 1

Attachments (2)

ifxusb_compat.patch (2.2 KB) - added by mkresin 2 years ago.
lantiq_kernel41_compat.patch (9.8 KB) - added by mkresin 2 years ago.

Download all attachments as: .zip

Change History (21)

Changed 2 years ago by mkresin

comment:1 Changed 2 years ago by mkresin

IRQF_DISABLED was removed from kernel 4.1 with commit d8bf368d0631d4bc2612d8bf2e4e8e74e620d0cc.

Would you please test whether USB still works for you with the attached patch applied.

comment:2 Changed 2 years ago by juanriccio@…

I personally have no USB device to check it with, unless a pendrive qualifies. However, I don't know much about mounting FAT32 filesystems (that's my pen), and I am not sure about applying the patch, so I hope someone can take on this bit of testing.
Thanks for the quick response!

comment:3 Changed 2 years ago by guraltsev

I applied the patch but there is still a problem with IRQF_DISABLED in other files:

/home/guraltsev/admin/OpenWRT/openwrt/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/drv_vmmc-1.9.0/src/mps/drv_mps_vmmc_linux.c: In function 'ifx_mps_init_module':
/home/guraltsev/admin/OpenWRT/openwrt/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/drv_vmmc-1.9.0/src/mps/drv_mps_vmmc_linux.c:2265:43: error: 'IRQF_DISABLED' undeclared (first use in this function)
                          ifx_mps_ad0_irq, IRQF_DISABLED

Changed 2 years ago by mkresin

comment:4 Changed 2 years ago by mkresin

Please revert the changes from the last patch and test with attachment:lantiq_kernel41_compat.patch

Last edited 2 years ago by mkresin (previous) (diff)

comment:5 follow-up: Changed 2 years ago by DocMAX

same issue here with Buffalo WBMR300

comment:6 in reply to: ↑ 5 Changed 2 years ago by mkresin

Replying to DocMAX:

same issue here with Buffalo WBMR300

Yeah, all ar9 based boards are affected. Maybe every lantiq board except for the VRX based ones.

Am I right, that you did not applied attachment:lantiq_kernel41_compat.patch before compiling? With the patch applied, a WBMR300 build finishes successfully for me.

But I will not send this untested patch to the openwrt-devel mailing list, until:

  • I do get the confirmation that it the patch (compile) works for others than me
  • USB still works

Additionally, It would be beautiful if some can confirm, that the "TAPI LL driver for Voice Macro" (vmmc) still works.

comment:7 Changed 2 years ago by DocMAX

Did not apply the patch, because i dont know if this affects my next "git pull".
I dont want to mess things up.

comment:8 Changed 2 years ago by DocMAX

I think it happened at 47130 > 47131. Please fix!

Last edited 2 years ago by DocMAX (previous) (diff)

comment:9 Changed 2 years ago by juanriccio@…

The 4.1 kernel indeed. I think mkresin has a good grasp on the issue, but he needs testers before pushing out official patches. I reckon it won't take too long to find someone who can test the relevant bits.

comment:10 Changed 2 years ago by DocMAX

git: Patch does not have a valid e-mail address... wft?

Last edited 2 years ago by DocMAX (previous) (diff)

comment:11 Changed 2 years ago by DocMAX

The patch works!

comment:12 Changed 2 years ago by mkresin

Would you please report what you have tested?

  • compiling?
  • usb?
  • TAPI LL driver for Voice Macro" (vmmc)?

comment:13 Changed 2 years ago by anonymous

Please fix. Error still there:

mkdir -p /home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/.tmp_versions ; rm -f /home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/.tmp_versions/*
make -f ./scripts/Makefile.build obj=/home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9

mips-openwrt-linux-musl-gcc -Wp,-MD,/home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/.ifxusb_cif_h.o.d -nostdinc -isystem /home/docmax/openwrt/trunk/staging_dir/toolchain-mips_34kc+dsp_gcc-4.8-linaro_musl-1.1.11/lib/gcc/mips-openwrt-linux-musl/4.8.3/include -I./arch/mips/include -Iarch/mips/include/generated/uapi -Iarch/mips/include/generated -Iinclude -I./arch/mips/include/uapi -Iarch/mips/include/generated/uapi -I./include/uapi -Iinclude/generated/uapi -include ./include/linux/kconfig.h -DKERNEL -DVMLINUX_LOAD_ADDRESS=0xffffffff80002000 -DDATAOFFSET=0 -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -std=gnu89 -mno-check-zero-division -mabi=32 -G 0 -mno-abicalls -fno-pic -pipe -mno-branch-likely -msoft-float -DGAS_HAS_SET_HARDFLOAT -Wa,-msoft-float -ffreestanding -march=mips32r2 -Wa,-mips32r2 -Wa,--trap -I./arch/mips/include/asm/mach-lantiq -I./arch/mips/include/asm/mach-lantiq/xway -I./arch/mips/include/asm/mach-generic -fno-delete-null-pointer-checks -O2 -fno-reorder-blocks -fno-tree-ch -fno-caller-saves --param=allow-store-data-races=0 -Wframe-larger-than=1024 -fstack-protector -Wno-unused-but-set-variable -fomit-frame-pointer -fno-var-tracking-assignments -g -femit-struct-debug-baseonly -fno-var-tracking -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fconserve-stack -Werror=implicit-int -Werror=strict-prototypes -DCC_HAVE_ASM_GOTO -DIS_AR9 -DIS_DUAL -DUNALIGNED_BUF_ADJ -Dlinux -DLINUX -DIS_HOST -DKERNEL -DDYN_SOF_INTR -DUEIP -DDO_OC_INT -DINNAKSTOP_BULK -DINTRNAKRETRY -DINTRINCRETRY -DMODULE -mno-long-calls -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(ifxusb_cif_h)" -D"KBUILD_MODNAME=KBUILD_STR(ltq_hcd_ar9)" -c -o /home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/ifxusb_cif_h.o /home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/ifxusb_cif_h.c

/home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/ifxusb_cif_h.c: In function 'ifxusb_oc_int_on':
/home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/ifxusb_cif_h.c:1177:11: error: 'IRQF_DISABLED' undeclared (first use in this function)

| IRQF_DISABLED


/home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/ifxusb_cif_h.c:1177:11: note: each undeclared identifier is reported only once for each function it appears in
scripts/Makefile.build:258: recipe for target '/home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/ifxusb_cif_h.o' failed
make[5]: * /home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/ifxusb_cif_h.o Error 1
Makefile:1384: recipe for target '_module_/home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9' failed
make[4]:
* [_module_/home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9] Error 2
make[4]: Leaving directory '/home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/linux-4.1.10'
Makefile:49: recipe for target '/home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/.built' failed
make[3]: * /home/docmax/openwrt/trunk/build_dir/target-mips_34kc+dsp_musl-1.1.11/linux-lantiq_xway/ltq-hcd-ar9/.built Error 2
make[3]: Leaving directory '/home/docmax/openwrt/trunk/package/kernel/lantiq/ltq-hcd'
package/Makefile:191: recipe for target 'package/kernel/lantiq/ltq-hcd/compile' failed
make[2]:
* [package/kernel/lantiq/ltq-hcd/compile] Error 2
make[2]: Leaving directory '/home/docmax/openwrt/trunk'
package/Makefile:188: recipe for target '/home/docmax/openwrt/trunk/staging_dir/target-mips_34kc+dsp_musl-1.1.11/stamp/.package_compile' failed
make[1]: * /home/docmax/openwrt/trunk/staging_dir/target-mips_34kc+dsp_musl-1.1.11/stamp/.package_compile Error 2
make[1]: Leaving directory '/home/docmax/openwrt/trunk'
/home/docmax/openwrt/trunk/include/toplevel.mk:177: recipe for target 'world' failed
make:
* [world] Error 2

comment:14 Changed 2 years ago by mkresin

DocMax,

would you please double check whether attachment:lantiq_kernel41_compat.patch​ is applied! This error should be fixed by the patch.

I mean, one day ago, you reported that the patch is working (without any details of course). This isn't an on/off thing. Either the patch works or it doesn't.

And please, test the stuff I've requested!

comment:15 Changed 2 years ago by anonymous

the patch works!!
but i dont want to apply the fix on every update! please commit this to the builds!

comment:16 Changed 2 years ago by mkresin

Okay, this is the last time I write this. If I do not get a qualified answer, I will stop working on this. This is to time consuming. Especially since I don't own a device that is affected by this bug. My concern was only to help some strangers.

Please report back what works:

  • compiling?
  • USB?
  • TAPI LL driver for Voice Macro" (vmmc)?

please commit this to the builds!

I'm not an OpenWrt developer and I don't have commit rights. I can only propose patches, which possibly get applied. But I don't propose an untested patch.

comment:17 Changed 2 years ago by anonymous

compiling and USB works.
but how do i test vmmc? i dont even know what this is.

comment:18 Changed 2 years ago by mkresin

The Lantiq SoCs have a 2nd mips core called "voice mips macro core (vmmc)" which is used to run the voice firmware.[1]

It's related to the telephony ports on some devices[2]. I would expect this core to do the analogue to digital transformation in hardware.

I already expected that it would be challenging to find someone who owns a device with populated telephony ports + a working telephony setup and the willingness to test the patch. Therefore, I send the patch to the openwrt-devel mailing list minutes ago.

[1] http://patchwork.linux-mips.org/patch/8042/
[2] https://github.com/Entware/openwrt-telephony/blob/master/net/asterisk-1.8.x/src-lantiq/configs/lantiq.conf.sample

comment:19 Changed 2 years ago by DocMAX

thank you so much!

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.