Modify

Opened 2 years ago

Last modified 2 years ago

#20516 new defect

Image generator doesn't use latest files

Reported by: yuvadm Owned by: developers
Priority: response-needed Milestone: Bugs Paradise
Component: base system Version: Trunk
Keywords: Cc:

Description

There's a regression in the latest Image Generator in Chaos Calmer, where you build a standard image:

$ make image PROFILE="profile" FILES=files/"

Now, if you change one of the files (in files/) and try to build again, that change will not be reflected in the build.

Running make clean doesn't solve this either. Only when deleting the entire IG directory and building again, do you get the file change.

I didn't debug this further to understand where exactly the files are cached, but this is clearly different from the behavior in BB IG.

Attachments (0)

Change History (6)

comment:1 Changed 2 years ago by anonymous

There is definitely an issue with "FILES=", some might end up in the build, others might not. I have got locked out of a TL-MR3220 twice so far.

No such issues with Image Generator for BB. The other options (profile & packages) seem to work fine.

comment:2 Changed 2 years ago by jow

Anything special about your files/ tree? Like symlinks, executable permissions?

comment:3 Changed 2 years ago by anonymous

This is all of them:

$ ls -Rlhn 
.:
total 8.0K
drwxr-xr-x. 6 1000 1000 4.0K Sep 24 00:32 etc
drwxr-xr-x. 2 1000 1000 4.0K Sep 23 22:45 root

./etc:
total 44K
-rw-r--r--. 1 1000 1000 1.2K Sep 23 22:49 banner
drwxr-xr-x. 2 1000 1000 4.0K Sep 23 23:14 config
drwxr-xr-x. 2 1000 1000 4.0K Dec  3  2014 crontabs
drwx------. 2 1000 1000 4.0K Dec  2  2014 dropbear
-rw-rw-r--. 1 1000 1000  190 Dec  2  2014 passwd
-rw-rw-r--. 1 1000 1000  190 Dec  2  2014 passwd-
-rw-r--r--. 1 1000 1000  475 Sep 23 22:50 rc.local
-rw-------. 1 1000 1000  153 Dec  2  2014 shadow
-rw-------. 1 1000 1000  153 Dec  2  2014 shadow-
-rw-r--r--. 1 1000 1000  808 Dec  2  2014 sysctl.conf
drwxr-xr-x. 2 1000 1000 4.0K Dec  3  2014 uci-defaults

./etc/config:
total 36K
-rw-r--r--. 1 1000 1000  367 Dec  7  2014 ddns
-rw-rw-r--. 1 1000 1000  105 Dec  2  2014 ddns.sample
-rw-r--r--. 1 1000 1000  564 Dec  7  2014 dhcp
-rw-r--r--. 1 1000 1000  219 Dec  7  2014 dropbear
-rw-r--r--. 1 1000 1000 1.1K Dec  7  2014 firewall
-rw-r--r--. 1 1000 1000  727 Sep 23 23:14 network
-rw-r--r--. 1 1000 1000 1.3K Sep 23 22:55 system
-rw-r--r--. 1 1000 1000  326 Dec  7  2014 uhttpd
-rw-r--r--. 1 1000 1000  323 Sep 23 22:54 wireless

./etc/crontabs:
total 4.0K
-rw-rw-r--. 1 1000 1000 71 Dec  3  2014 root

./etc/dropbear:
total 8.0K
-rw-------. 1 1000 1000 458 Dec  2  2014 dropbear_dss_host_key
-rw-------. 1 1000 1000 805 Dec  2  2014 dropbear_rsa_host_key

./etc/uci-defaults:
total 4.0K
-rwxrwxr-x. 1 1000 1000 165 Dec  3  2014 99_user_mods

./root:
total 8.0K
-rwxr-xr-x. 1 1000 1000 121 Dec  3  2014 cleanup
-rwxr-xr-x. 1 1000 1000 446 Sep 23 22:45 ping-reboot


Are there any settings that can't be ported over from BB?

comment:4 Changed 2 years ago by anonymous

And I can confirm the OP's finding, if I delete the Image Generator folder and start afresh, there is no problem. I have performed ~20 build-delete cycles so far and all of the images work as expected.

comment:5 Changed 2 years ago by jow

  • Priority changed from high to response-needed

I tried to reproduce the report but was unable to confirm your finding.
The test procedure was:

1) download and unpack the ar71xx/generic imagebuilder for 15.05
2) mkdir files/
3) echo "abc" > files/test.txt
4) make image PROFILE=UAPRO FILES=files/
5) cat build_dir/target-mips_34kc_uClibc-0.9.33.2/root-ar71xx/hello.txt -> "abc"
6) echo "def" > files/test.txt
7) make image PROFILE=UAPRO FILES=files/
8) cat build_dir/target-mips_34kc_uClibc-0.9.33.2/root-ar71xx/hello.txt -> "def"

Afterwards I repeated the procedure after editing .config to set CONFIG_TARGET_ROOTFS_TARGZ=y, then I inspected the resulting bin/ar71xx/openwrt-15.05-ar71xx-generic-UAPPRO-rootfs.tar.gz after each edit/make run and it properly reflected the changes.

Can you please run the same procedure and report your findings? If build_dir/ and .tar.gz reflect your changes but the .bin images not then maybe your images are too large and simply not rebuilt? Check the file modification times in this case please.

comment:6 Changed 2 years ago by anonymous

Hello, I'm sorry it took me so long to reply, but I was AFK for a few weeks and when I got back I had completely forgotten about this ticket.

I have followed your procedure above and I am getting the exact same results. I've even tried modifying the files I had issues with in such a way as to keep their bytesize constant, but everything worked as expected.

Currently I don't have any machines to test on and the firmware-mod-kit can't open the factory.bin files, so it might be a while before I investigate further.

Could there be a problem with the upgrade procedure? I have only performed this on routers that already ran BB and I had upgraded them with "sysupgrade -v -n /tmp/factory.bin".

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.