Modify

Opened 3 years ago

Last modified 3 years ago

#19718 new enhancement

CC 15.05-rc1 includes .gitignore

Reported by: anonymous Owned by: developers
Priority: normal Milestone: Chaos Calmer 15.05
Component: base system Version: Trunk
Keywords: Cc:

Description

Please remove /lib/uci/.gitignore, this is not necessary in the finished images.

Attachments (0)

Change History (4)

comment:1 Changed 3 years ago by anonymous

/lib/uci/upload/.gitignore, not /lib/uci/.gitignore

comment:2 Changed 3 years ago by hnyman

The same .gitignore file is found also in the trunk builds (in /rom, not in overlay) so it is not just due to rc1 building config.

root@OpenWrt:/# grep r4  /etc/banner
 CHAOS CALMER (Bleeding Edge, r45715)

root@OpenWrt:/# ls -la /rom/lib/uci/upload/
drwxrwxr-x    2 root     root            33 May 23 17:11 .
drwxrwxr-x    3 root     root            29 May 23 17:11 ..
-rw-rw-r--    1 root     root             0 Apr 23 19:09 .gitignore

The interesting part is that I find it in the staging_dir with file & directory timestamp from April when I re-built my build environment. Those dates have survived both make clean and make dirclean, which have removed the whole staging_dir several time. That suggests that the file is found somewhere in the sources and that it gets copied here in the make process, possibly from some other package than uci itself.

perus@vb1504:/Openwrt/trunk$ ls -la staging_dir/target-mips_34kc_uClibc-0.9.33.2/root-ar71xx/lib/uci/upload/
total 8
drwxr-xr-x 2 perus perus 4096 huhti 23 19:09 .
drwxr-xr-x 3 perus perus 4096 huhti 23 19:09 ..
-rw-rw-r-- 1 perus perus    0 huhti 23 19:09 .gitignore

comment:3 Changed 3 years ago by hnyman

The file is coming from "luci-base":
https://github.com/openwrt/luci/blob/master/modules/luci-base/root/lib/uci/upload/.gitignore

The file has been created by: https://github.com/openwrt/luci/commit/6324fc0caa3bca03c3e7334cc4626da08a0a5c56
"modules/base: restore /lib/uci/upload directory" from jow.

The file might be just an error in the changeset, or it might be needed as a placeholder guaranteeing the creation of the default upload directory (as defined in https://github.com/openwrt/luci/blob/master/modules/luci-base/root/etc/config/luci#L13 ).

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.