Modify

Opened 3 years ago

Last modified 3 years ago

#19538 reopened defect

jffs2 and ubifs must support RENAME_EXCHAGE for the new overlayfs

Reported by: anonymous Owned by: developers
Priority: normal Milestone:
Component: packages Version: Trunk
Keywords: Cc:

Description

The new overlayfs in 3.18 requires the underlying file system to support both RENAME_WHITEOUT and RENAME_EXCHANGE. RENAME_WHITEOUT was added for jffs2 in r45362. But RENAME_EXCHANGE still needs to be implemented. This affects moving, or deleting directories that only exist in the lower layer. A similar ticket describes these issues: #19432

Attachments (0)

Change History (6)

comment:1 Changed 3 years ago by nbd

  • Resolution set to fixed
  • Status changed from new to closed

fixed in r45580

comment:2 Changed 3 years ago by nbd

that fix applies to jffs2. i will deal with ubifs later.

comment:3 Changed 3 years ago by wrtpat

Interested in the ubifs portion of the fix.
Will a new ticket be opened for that?
Or, should I bookmark this ticket, and keep an eye out for it?

comment:4 Changed 3 years ago by anonymous

After this patch I am able to move and delete directories that only exist in the lower layer file system. But, I did notice that for every RENAME_EXCHANGE operation on a lower layer jffs2 directory it creates an orphan in the jffs2 xattr subsystem. I think this is related to the way the new overlayfs uses the "trusted.overlay.opaque" xattr for opaque directories.

As an example, if I remove a directory that only exists in the lower layers the next time the hardware is rebooted (or whenever the jffs2 overlay is mounted again) dmesg will report a new xattr orphan: jffs2: notice: (382) jffs2_build_xattr_subsystem: complete building xattr subsystem, 1 of xdatum (0 unchecked, 1 orphan) and 1 of xref (0 dead, 1 orphan) found.

I am not sure if having xattr orphans is a long term problem for jffs2?

comment:5 Changed 3 years ago by wrtpat

reopening this.
It appears this is still not fixed for ubifs in CC rc3.

comment:6 Changed 3 years ago by wrtpat

  • Resolution fixed deleted
  • Status changed from closed to reopened

Add Comment

Modify Ticket

Action
as reopened .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.