Modify

Opened 3 years ago

#19392 new defect

[PATCH][toolchain/wrapper] Not support comma symbol in CFLAGS

Reported by: chenkaie Owned by: developers
Priority: high Milestone: Bugs Paradise
Component: toolchain Version: Trunk
Keywords: wrapper cflags Cc:

Description

Hi all,

I found an defect in openwrt/toolchain/wrapper/Makefile when "," comma symbol is used in the CFLGAS as below

  CFLAGS="-mfpu=neon -Wa,-mimplicit-it=thumb"

Then below command will be error, since "," symbol should be carefully handled in Makefile

# 1: config symbol
# 2: feature
define toolchain_test
$$(if $$($(1)), \
	@echo -n "Testing external toolchain for $(2) support ... "; \
	if $(call toolchain_util,--test "$(2)"); then \
		echo "ok"; exit 0; \
	else \
		echo "failed"; \
		echo "ERROR: $(1) is enabled but the external toolchain does not support it"; \
		exit 1; \
	fi)
endef

An patch was attached FYR, please help to review thanks.

Attachments (1)

100-support-comma-symbol-in-cflags.patch (786 bytes) - added by chenkaie 3 years ago.

Download all attachments as: .zip

Change History (1)

Changed 3 years ago by chenkaie

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.