Modify

Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#1936 closed defect (fixed)

broadcom-diag: platform_detect fails on motorola wr850gp

Reported by: dairiki@… Owned by: mbm
Priority: normal Milestone:
Component: base system Version:
Keywords: wr850gp motorola Cc:

Description

My routers model was not being correctly autodetected. I have a motorola wr850gp. It was detected as a Trendware TEW-411BRP+. Here's what I did to fix platform_detect:

--- package/broadcom-diag/src/diag.c.orig       2007-05-08 11:47:57.000000000 -0700
+++ package/broadcom-diag/src/diag.c    2007-06-21 07:22:46.000000000 -0700
@@ -636,6 +636,7 @@
        }

        if (!strcmp(getvar("CFEver"), "MotoWRv203") ||
+               !strcmp(getvar("CFEver"), "MotoWRv301") ||
                !strcmp(getvar("MOTO_BOARD_TYPE"), "WR_FEM1")) {

                return &platforms[WR850GV2V3];

(I've attached an nvram dump of my router, in case that's of help.)


After the above patch LED control works as follows (I'm not sure this is correct w.r.t. control of the "Modem"" LED):

/proc/diag/led/power "Power" LED
0 Red
1 Green


/proc/diag/led/diag /proc/diag/led/dmz "Modem" LED
0 0 off
1 0 Red
0 1 Yellow
1 1 Yellow


/proc/diag/led/wlan "Wireless" LED
0 off
1 Green

(Note that when nas is running, it controls the "Wireless"" LED.)

Attachments (1)

wr850gp_nvram.txt (10.5 KB) - added by dairiki@… 11 years ago.
nvram dump from (non-virgin) motorola wr850gp

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by dairiki@…

nvram dump from (non-virgin) motorola wr850gp

comment:1 Changed 11 years ago by mbm

  • Owner changed from developers to mbm

added the WR850GP and did a cleanup -
http://mbm.openwrt.org/diag.diff

comment:2 Changed 11 years ago by mbm

  • Resolution set to fixed
  • Status changed from new to closed

fixed in [7876]

comment:3 Changed 10 years ago by hugh@…

  • Resolution fixed deleted
  • Status changed from closed to reopened

I have Motorola WR850G, version 2. It is currently misidentified by diag as a Trendware TEW411BRP+.

The proposed patch does not fix this problem, but one like it should do so.

On my router

nvram get CFEver

yields

MotoWRv207

and

nvram get MOTO_BOARD_TYPE

yields nothing.

Ipropose the addition of another clause to the same "if".

!strcmp(getvar("CFEver"), "MotoWRv207")
Motorola WR850Gv2

Here is a patch against https://dev.openwrt.org/browser/trunk/package/broadcom-diag/src/diag.c.
Since that does not contain the wr850gp fix, it is included in my patch.

--- diag.c.ORIG 2007-09-30 15:19:30.000000000 -0400
+++ diag.c      2007-09-30 15:23:36.000000000 -0400
@@ -714,6 +714,8 @@
        }

        if (!strcmp(getvar("CFEver"), "MotoWRv203") ||
+               !strcmp(getvar("CFEver"), "MotoWRv207") ||      // Motorola WR850Gv2
+               !strcmp(getvar("CFEver"), "MotoWRv301") ||      // Motorola WR850GP
                !strcmp(getvar("MOTO_BOARD_TYPE"), "WR_FEM1")) {

                return &platforms[WR850GV2V3];

comment:4 Changed 10 years ago by nbd

  • Resolution set to fixed
  • Status changed from reopened to closed

fixed in [9492]

comment:5 Changed 10 years ago by hugh@…

nbd checked in a slightly more general fix. Works for me. Thanks.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.