Modify

Opened 3 years ago

Closed 3 years ago

#19087 closed defect (fixed)

samba: opkg upgrade samba36-server overwrites config file

Reported by: joaochainho@… Owned by: developers
Priority: normal Milestone:
Component: packages Version: Trunk
Keywords: samba Cc:

Description

Hi,
I noticed that upgrading the samba36-server package via opkg overwrites the UCI config file.
I went looking into the source files and found that there is no 'conffiles' definition in Makefile.
So I suggest the following patch. Hope it helps.

Index: package/network/services/samba36/Makefile
===================================================================
--- package/network/services/samba36/Makefile	(revision 44539)
+++ package/network/services/samba36/Makefile	(working copy)
@@ -61,6 +61,10 @@
  to as the LanManager or Netbios protocol.
 endef
 
+define Package/samba36-server/conffiles
+/etc/config/samba
+endef
+
 TARGET_CFLAGS += -DMAX_DEBUG_LEVEL=$(CONFIG_PACKAGE_SAMBA_MAX_DEBUG_LEVEL) -D__location__=\\\"\\\" -ffunction-sections -fdata-sections
 TARGET_LDFLAGS += -Wl,--gc-sections
 
@@ -125,7 +129,7 @@
 
 define Package/samba36-server/install
 	$(INSTALL_DIR) $(1)/etc/config
-	$(INSTALL_DATA) ./files/samba.config $(1)/etc/config/samba
+	$(INSTALL_CONF) ./files/samba.config $(1)/etc/config/samba
 	$(INSTALL_DIR) $(1)/etc/samba
 	$(INSTALL_DATA) ./files/smb.conf.template $(1)/etc/samba
 	$(INSTALL_DATA) $(PKG_BUILD_DIR)/codepages/lowcase.dat $(1)/etc/samba

Attachments (0)

Change History (1)

comment:1 Changed 3 years ago by blogic

  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.