Modify

Opened 3 years ago

#19016 new defect

keepalive handler in ppp.sh is broken in BB 14.07

Reported by: anonymous Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: packages Version: Barrier Breaker 14.07
Keywords: pptp keepalive Cc:

Description

/lib/netifd/proto/ppp.sh contains wrong handler for keepalive.
keepalive is a sting like '0 5'
the first number is number of fails, the second is the interval

This part is a wrong one

  [ "${keepalive:-0}" -lt 1 ] && keepalive=""  #<----here
        [ -n "$mtu" ] || json_get_var mtu mtu
        [ -n "$pppname" ] || pppname="${proto:-ppp}-$config"

        local interval="${keepalive##*[, ]}"
        [ "$interval" != "$keepalive" ] || interval=5
        [ -n "$connect" ] || json_get_var connect connect
        [ -n "$disconnect" ] || json_get_var disconnect disconnect

Example

keepalive='0 5'; [ "${keepalive:-0}" -lt 1 ] && keepalive=""
ash: 0 5: bad number

Attachments (0)

Change History (0)

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.