Modify

Opened 3 years ago

Last modified 3 years ago

#18909 new enhancement

Git submodules support in scripts/feeds

Reported by: rooter@… Owned by: developers
Priority: normal Milestone:
Component: packages Version: Trunk
Keywords: Cc:

Description

I attach patch enabling support for submodules in git feeds. Works fine when used against trunk (tried on r44245) and barrier breaker (r43857). My particular use case for it is compiling my personal package feed while incorporating packages from other github repositories. IMHO there are no drawbacks for implementing this feature.

I tried to keep patch minimal, but this way sprintf function sometimes is supplied with more than enough arguments (can result in warnings in future versions of perl). If it will be deemed inadequate, but the feature proposal would be accepted I can refactor the feeds script a little more to avoid this.

Attachments (0)

Change History (2)

comment:2 Changed 3 years ago by acinonyx

Relying on Git submodules in general to resolve dependencies ties a project to the version control system. I try to avoid it, unless my project source code is indeed broken down into submodules which are not complete by themselves and need to be assembled together before compiling.

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.