Modify

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#1887 closed defect (wontfix)

adm5120 USB host controller not enabled, and not configurable.

Reported by: bifferos Owned by: developers
Priority: normal Milestone:
Component: packages Version:
Keywords: Cc:

Description

According to target/linux/adm5120-2.6/config/default this should be compiled-in, but it doesn't seem to work. I would expect the message: "ADM5120 USB Host Controller Driver" on boot but it doesn't come up. Also, no log messages when inserting devices.

Here is a fairly feeble attempt to make the driver a module:

diff --git a/package/kernel/modules/usb.mk b/package/kernel/modules/usb.mk
index 3094dbe..a9efac3 100644
--- a/package/kernel/modules/usb.mk
+++ b/package/kernel/modules/usb.mk
@@ -90,6 +90,19 @@ define KernelPackage/usb-ohci/2.6
 endef
 $(eval $(call KernelPackage,usb-ohci))

+define KernelPackage/usb-adm5120-hcd
+  $(call usbdep,)
+  TITLE:=Support for ADM5120 HCD controller
+  DESCRIPTION:=Kernel support for ADM5120 HCD controllers
+endef
+
+define KernelPackage/usb-adm5120-hcd/2.6
+  FILES:=$(LINUX_DIR)/drivers/usb/host/adm5120-hcd.ko
+  KCONFIG:=$(CONFIG_USB_ADM5120_HCD)
+  AUTOLOAD:=$(call AutoLoad,50,usb-adm5120-hcd)
+endef
+$(eval $(call KernelPackage,usb-adm5120-hcd))
+
 define KernelPackage/usb2
   $(call usbdep,)
   TITLE:=Support for USB2 controllers
diff --git a/target/linux/adm5120-2.6/config/default b/target/linux/adm5120-2.6/config/default
index 4aeffad..83dcba0 100644
--- a/target/linux/adm5120-2.6/config/default
+++ b/target/linux/adm5120-2.6/config/default
@@ -251,7 +251,7 @@ CONFIG_TRAD_SIGNALS=y
 CONFIG_USB=y
 # CONFIG_USBPCWATCHDOG is not set
 # CONFIG_USB_ACM is not set
-CONFIG_USB_ADM5120_HCD=y
+CONFIG_USB_ADM5120_HCD=m
 # CONFIG_USB_CATC is not set
 # CONFIG_USB_EHCI_HCD is not set
 # CONFIG_USB_ET61X251 is not set

Unfortunately, it doesn't work:

root@OpenWrt:/lib/modules# insmod adm5120-hcd.ko
adm5120_hcd: Unknown symbol adm5120_board
insmod: cannot insert 'adm5120-hcd.ko': Success (2): Success

Attachments (0)

Change History (2)

comment:1 Changed 11 years ago by florian

  • Resolution set to wontfix
  • Status changed from new to closed

This is not the way we want it to act. The ADM5120 HCD should be built in the kernel and it detects whether the board supports USB or not (flash has_usb in adm5120_board). Now why it does not work currently, it is because the driver is broken and has been fully migrated to the Linux USB API.

comment:2 Changed 11 years ago by anonymous

OK. I was looking at the forum article http://forum.openwrt.org/viewtopic.php?id=10926
it says "USB has been rewritten but needs testing". This is presumably wrong. It can't be tested if it won't compile.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.