Modify

Opened 3 years ago

Closed 3 years ago

#18821 closed defect (fixed)

r44113 broke kernel 3.8 based platforms in buildbot (8250.ko vs 8250_core.ko)

Reported by: hnyman Owned by: developers
Priority: normal Milestone: Chaos Calmer 15.05
Component: kernel Version: Trunk
Keywords: Cc:

Description

Looks like the simplification of kernel version checks a few days ago caused one more bug for some platforms.

r44113 simplified also package/kernel/linux/modules/other.mk regarding serial 8250:
https://dev.openwrt.org/browser/trunk/package/kernel/linux/modules/other.mk?rev=44113#L701

 -  FILES:=$(LINUX_DIR)/drivers/tty/serial/8250/8250$(if $(call kernel_patchver_ge,3.7),$(if $(call kernel_patchver_le,3.8),_core)).ko
 +  FILES:=$(LINUX_DIR)/drivers/tty/serial/8250/8250.ko

Based on the previous version of the file, it looks like platforms using old kernels 3.7 and 3.8 need 8250_core.ko instead of 8250.ko. And there are still a few 3.8 based platforms being built.

Buildbot chokes now on 3.8 based platforms. For example,
http://buildbot.openwrt.org:8010/builders/adm5120/builds/688/steps/compile_5/logs/stdio
http://buildbot.openwrt.org:8010/builders/ep93xx/builds/703/steps/compile_5/logs/stdio

ERROR: module '/home/buildbot/slave/ep93xx/build/build_dir/target-arm_arm920t_uClibc-0.9.33.2_eabi/linux-ep93xx/linux-3.8.13/drivers/tty/serial/8250/8250.ko' is missing.
make[2]: *** [/home/buildbot/slave/ep93xx/build/bin/ep93xx/packages/base/kmod-serial-8250_3.8.13-1_ep93xx.ipk] Error 1

Attachments (0)

Change History (1)

comment:1 Changed 3 years ago by nbd

  • Resolution set to fixed
  • Status changed from new to closed

fixed in r44154

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.