Modify

Opened 3 years ago

Closed 3 years ago

#18813 closed defect (fixed)

One ")" too much in hwmon.mk since r44114?

Reported by: hnyman Owned by: developers
Priority: normal Milestone: Chaos Calmer 15.05
Component: base system Version: Trunk
Keywords: Cc:

Description

Looks like r44114 has killed all platforms in buildbot. (Last ok builds were from 44111)
http://buildbot.openwrt.org:8010/grid

Error in all platforms is:

Package kmod-hwmon-adt7410 is missing dependencies for the following libraries:
adt7x10.ko

In r44106-r44119 there were several changes related to eliminating kernel 3.3 and related stuff, and this is probably related to that. r44114 eliminated some complex version checks, but apparently introduced a bug thanks to a typo.

It seems to me that line 49 in hwmon.ko has one ")" too much:
ifeq ($(CONFIG_LINUX_3_8)),)
https://dev.openwrt.org/browser/trunk/package/kernel/linux/modules/hwmon.mk?rev=44114#L49

It should probably be just:
ifeq ($(CONFIG_LINUX_3_8),)

Attachments (0)

Change History (1)

comment:1 Changed 3 years ago by nbd

  • Resolution set to fixed
  • Status changed from new to closed

fixed in r44120

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.