Modify

Opened 11 years ago

Closed 11 years ago

Last modified 4 years ago

#1801 closed defect (fixed)

[FIX] mini_fo dir corruption 2.6.21.2 (also Ticket #1502)

Reported by: b.sander Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: kernel Version:
Keywords: mini_fo unmount corruption 2.6 kernel dir Cc:

Description

--- linux-2.6.21.1/fs/mini_fo/inode.bak	2007-05-27 12:38:24.000000000 +0200
+++ linux-2.6.21.1/fs/mini_fo/inode.c	2007-06-01 23:24:30.000000000 +0200
@@ -552,9 +552,6 @@
 		down(&hidden_sto_dir_dentry->d_inode->i_sem);
 #endif
 
-		/* avoid destroying the hidden inode if the file is in use */
-		dget(hidden_sto_dentry);
-
 		/* Delete an old WOL file contained in the storage dir */
 		meta_dentry = lookup_one_len(META_FILENAME, 
 					     hidden_sto_dentry, 
@@ -645,9 +642,6 @@
 		down(&hidden_sto_dir_dentry->d_inode->i_sem);
 #endif
 
-		/* avoid destroying the hidden inode if the file is in use */
-		dget(hidden_sto_dentry);
-
 		/* Delete an old WOL file contained in the storage dir */
 		meta_dentry = lookup_one_len(META_FILENAME, 
 					     hidden_sto_dentry, 
@@ -693,9 +687,6 @@
 		down(&hidden_sto_dir_dentry->d_inode->i_sem);
 #endif
 
-		/* avoid destroying the hidden inode if the file is in use */
-		dget(hidden_sto_dentry);
-
 		/* Delete an old WOL file contained in the storage dir */
 		meta_dentry = lookup_one_len(META_FILENAME, 
 					     hidden_sto_dentry,

Regards,
b.sander

Attachments (0)

Change History (5)

comment:1 follow-up: Changed 11 years ago by nbd

I have my doubts about the correctness of that fix, especially since you didn't remove the dput() calls that came with the dget().
Could you explain what you did there and why it fixes the problems?

comment:2 Changed 11 years ago by b.sander

from git, but doesn't fix Ticket #1502 (some interfere with other tests) -- sorry

comment:3 in reply to: ↑ 1 Changed 11 years ago by anonymous

Replying to nbd:

Could you explain what you did there and why it fixes the problems?

I added a fix for Ticket #1502, please have a look.

comment:4 Changed 11 years ago by nbd

  • Resolution set to fixed
  • Status changed from new to closed

fix added in [7676]

comment:5 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.