Modify

Opened 3 years ago

Last modified 3 years ago

#17985 new defect

possible error in lantiq,open-drain in dts

Reported by: dpeddi Owned by: developers
Priority: normal Milestone:
Component: packages Version: Trunk
Keywords: Cc:

Description

Hi,

I've found a possible error in following DTS:

EASY50712.dts: lantiq,open-drain;
EASY50810.dts: lantiq,open-drain;
EASY80920.dtsi: lantiq,open-drain;
P2601HNFX.dts: lantiq,open-drain;
VGV7519.dtsi: lantiq,open-drain;

source code clear od bit on <1> and set on <0>.

It seems to don't work correctly when value is omitted.

by comparing openocd dump_image of pinmux registry on original firmware and devmem on pinmux registry,
For VGV7519 correct value should be <0>.

Regards

Attachments (0)

Change History (3)

comment:1 Changed 3 years ago by dpeddi

I confirm the error for vgv7519. After set open-drain to <0> i can toggle leds. Before the change to dts the leds was always to their last status.

comment:2 Changed 3 years ago by dpeddi

Here is the patch:

diff --git a/target/linux/lantiq/dts/VGV7519.dtsi b/target/linux/lantiq/dts/VGV7519.dtsi
index aab8227..1470a22 100644
--- a/target/linux/lantiq/dts/VGV7519.dtsi
+++ b/target/linux/lantiq/dts/VGV7519.dtsi
@@ -63,7 +63,7 @@
                                                        "io21",
                                                        "io33",
                                                        "io7", "io44"; /* Internal ethernet phy leds */
-                                       lantiq,open-drain;
+                                       lantiq,open-drain = <0>;
                                        lantiq,pull = <0>;
                                        lantiq,output = <1>;
                                };

Last edited 3 years ago by dpeddi (previous) (diff)

comment:3 Changed 3 years ago by dpeddi

Here is the patch:

diff --git a/target/linux/lantiq/dts/VGV7519.dtsi b/target/linux/lantiq/dts/VGV7519.dtsi
index aab8227..1470a22 100644
--- a/target/linux/lantiq/dts/VGV7519.dtsi
+++ b/target/linux/lantiq/dts/VGV7519.dtsi
@@ -63,7 +63,7 @@
                                                        "io21",
                                                        "io33",
                                                        "io7", "io44"; /* Internal ethernet phy leds */
-                                       lantiq,open-drain;
+                                       lantiq,open-drain = <0>;
                                        lantiq,pull = <0>;
                                        lantiq,output = <1>;
                                };

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.