Modify

Opened 4 years ago

Closed 3 years ago

#16523 closed defect (fixed)

target/linux/ar7/patches-3.10/972-cpmac_fixup.patch is botched

Reported by: anonymous Owned by: florian
Priority: normal Milestone: Chaos Calmer 15.05
Component: kernel Version: Trunk
Keywords: Cc:

Description

the named patch needs to be reverted to make the network work on a T-Com Speedport W701V (http://wiki.openwrt.org/toh/t-com/spw701v).

in fact, it will panic with a BUG() with that patch.
it's possible to avoid the crash:

--- cpmac.c.orig        2014-05-11 09:33:10.090790733 +0200
+++ cpmac.c     2014-05-11 09:26:09.603348941 +0200
@@ -1178,7 +1178,7 @@
                        printk(KERN_ERR "%s: Could not attach to PHY\n",
                               dev->name);
                rc = PTR_ERR(priv->phy);
-               goto fail;
+               goto fail2;
        }

        if (netif_msg_probe(priv)) {
@@ -1189,6 +1189,8 @@
        }
        return 0;

+fail2:
+       unregister_netdev(dev);
 fail:
        free_netdev(dev);
        return rc;

but that doesn't make the network work, as the crash is in an error path anyway.

Attachments (0)

Change History (7)

comment:1 Changed 4 years ago by oswald.buddenhagen@…

this trac setup is insane. just sayin'. ;)

comment:2 Changed 4 years ago by florian

  • Owner changed from developers to florian
  • Status changed from new to accepted

comment:3 in reply to: ↑ description Changed 4 years ago by olebowle

No reboot loop anymore, thanks.

but that doesn't make the network work, as the crash is in an error path anyway.

Any idea how to fix that?

comment:4 follow-up: Changed 4 years ago by oswald.buddenhagen@…

as i said, by reverting the patch completely ... network works for me just fine without it.
the patch doesn't appear to be supposed to actually fix anything anyway.

comment:5 Changed 4 years ago by olebowle

Sorry I kind of misread your post. I removed the patch and the interface is coming up! Thanks again!

comment:6 in reply to: ↑ 4 Changed 3 years ago by florian

  • Status changed from accepted to assigned

comment:7 Changed 3 years ago by florian

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with r42169, r42168

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.