Modify

Opened 4 years ago

Last modified 4 years ago

#15848 new enhancement

TL-WR741ND V1,V2 enable USB support by default

Reported by: mexus@… Owned by: developers
Priority: normal Milestone: Chaos Calmer 15.05
Component: kernel Version: Trunk
Keywords: TL-WR741ND, USB support Cc:

Description

USB support is enabled for TL-WR741ND V4 by default, but not for V1 and V2. The USB mod is easier for V1 and V2. The situation is the same for TL-WR740N/ND

I have created a patch against r40695 to enable USB support for TL-WR741ND V1 and V2

--- target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wr741nd.c	2014-05-06 03:35:00.952658751 -0700
+++ target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wr741nd.c	2014-05-05 15:36:33.638449916 -0700
@@ -15,6 +15,7 @@
 #include "dev-ap9x-pci.h"
 #include "dev-eth.h"
 #include "dev-gpio-buttons.h"
+#include "dev-usb.h"
 #include "dev-leds-gpio.h"
 #include "dev-m25p80.h"
 #include "machtypes.h"
@@ -122,6 +123,9 @@
 
 	/* WAN port */
 	ath79_register_eth(0);
+	
+	/* USB port */
+	ath79_register_usb();
 
 	ap9x_pci_setup_wmac_led_pin(0, 1);
 	ap91_pci_init(ee, mac);

	
--- target/linux/ar71xx/patches-3.10/720-MIPS-ath79-TL-WR741ndV1V2-USB.patch	1969-12-31 16:00:00.000000000 -0800
+++ target/linux/ar71xx/patches-3.10//720-MIPS-ath79-TL-WR741ndV1V2-USB.patch	2014-05-05 12:12:10.000000000 -0700
@@ -0,0 +1,11 @@
+--- a/arch/mips/ath79/Kconfig
++++ b/arch/mips/ath79/Kconfig
+@@ -686,6 +686,7 @@
+ 	select ATH79_DEV_GPIO_BUTTONS
+ 	select ATH79_DEV_LEDS_GPIO
+ 	select ATH79_DEV_M25P80
++	select ATH79_DEV_USB
+ 
+ config ATH79_MACH_TL_WR741ND_V4
+ 	bool "TP-LINK TL-WR741ND v4/TL-MR3220 v2 support"
+ 

Attachments (1)

TL-WR741ND-USB_r40695.patch (1.1 KB) - added by mexus@… 4 years ago.
Enable USB support for TL-WR741ND v1 and v2 by default

Download all attachments as: .zip

Change History (12)

Changed 4 years ago by mexus@…

Enable USB support for TL-WR741ND v1 and v2 by default

comment:1 Changed 4 years ago by mexus@…

+++ target/linux/ar71xx/patches-3.10//720-MIPS-ath79-TL-WR741ndV1V2-USB.patch	2014-05-05 12:12:10.000000000 -0700

should be:

+++ target/linux/ar71xx/patches-3.10/720-MIPS-ath79-TL-WR741ndV1V2-USB.patch	2014-05-05 12:12:10.000000000 -0700

sorry for that!

comment:2 Changed 4 years ago by anonymous

I do not think that this should be there by default. By default none of this devices have USB. So it should be disabled on all of them that did not have USB build in by default and USB only via soldering on the PCB

comment:3 Changed 4 years ago by mexus@…

It's enabled by default for the same router different revision (V4).
I doesn't have USB! It needs mod and it's more complicated than the previous versions (it needs grinding the CPU chip).
Why shouldn't be enabled by default? Many people are making this mod. Is very easy.
Plus it doesn't eat a lot of space, I didn't add the kmod-usb packages to the manifest. So this is just a USB enabled kernel without the packages needed for USB support. It's few lines saving a lot of people a lot ot hustle leaning to compile, edit and so on.

comment:4 Changed 4 years ago by bittorf@…

please give us a number: kernel without USB and kernel-size with your enabled options

comment:5 Changed 4 years ago by mexus@…

How can I check the kernel size?

comment:6 Changed 4 years ago by bittorf@…

compile the normal kernel and check

bin/ar71xx/openwrt-ar71xx-generic-vmlinux.elf
and
openwrt-ar71xx-generic-vmlinux.lzma

after this, apply your symbols (make kernel_menuconfig) and
recompile with

make target/linux/{clean,compile}; make

and check the files again...

comment:7 Changed 4 years ago by anonymous

It would fit with and without the driver into the ROM. The mesurment of the kernelsize wont be neccecary.

Why it should not be included by default - because by default it is not included in the hardware. When you make modification then you should also make them to the software btw. just enable the additional driver.

Because of this additional driver for example someone maybe could not install some packages because of exactly this 5KB space that this by default (no soldering) useless usb driver takes. Also when its just 5byte of size - dont add this. People who make the soldering should add the things they soldered by themself to the firmware.

I also dont ask for default enabled LCD-screen driver because i "could" solder one to the chipset.

comment:8 Changed 4 years ago by mexus@…

As I said before: The same router V4 has USB enabled by default - it DOESN'T HAVE usb.
The CPU has USB support, so why not enable it? I'll check the size soon.
My logic is to have it disabled for all revisions or have it enabled for all revisions.
I don't think it will take 5Kb of space (5K is nothing BTW).

Yes I can compile it by myself but there are people that have the soldering but not the programing skills to make it. I don't want to include the driver with the firmware, just to enable the kernel to work with USB WHEN the usb driver is installed.

comment:9 Changed 4 years ago by bittorf@…

my proposal:
if those devices are really that popular for the usb-mod,
add a new profile for each WR741ND with suffix '-usbmod', so nobody
cares for bloat.

comment:10 Changed 4 years ago by mexus@…

The kernel sizes are the same:
openwrt-ar71xx-generic-vmlinux.elf
Patched size : 3165980
Original size: 3165980
openwrt-ar71xx-generic-vmlinux.lzma
Patched size : 1048576
Original size: 1048576

comment:11 Changed 4 years ago by anonymous

Why USB is been build into? Because juhosg was a bit lazy to make a separate profile for the 3220 v2 device.

/changeset/34779.html

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.