Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#15692 closed defect (fixed)

If 'file' is missing, build silently fails to strip binaries.

Reported by: chris.hodapp@… Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: toolchain Version: Trunk
Keywords: Cc:

Description

I am building from a fresh build environment as created from the attached Dockerfile. This occurs in a stock configuration.

The build is failing to strip the binaries if the 'file' command is missing. With 'make V=99', errors of this sort can be seen:

export CROSS="mips-openwrt-linux-uclibc-" NO_RENAME=1 ; NM="mips-openwrt-linux-uclibc-nm" STRIP="mips-openwrt-linux-uclibc-strip --strip-all" STRIP_KMOD="/home/openwrt/openwrt/scripts/strip-kmod.sh" /home/openwrt/openwrt/scripts/rstrip.sh /home/openwrt/openwrt/build_dir/target-mips_34kc_uClibc-0.9.33.2/toolchain/ipkg-ar71xx/libgcc
find: `file': No such file or directory

This causes the images to be much larger than they should be. With certain profiles, such as the WR703N, this silently prevents the firmware images from even being built. 'make V=99' shows errors of this sort being ignored:

[mktplinkfw] kernel length aligned to 1034484
[mktplinkfw] *** error: images are too big
make[5]: [install] Error 255 (ignored)

Since the buildroot installation wiki pages don't ever document that 'file' is a dependency, 'make defconfig' should probably be checking if 'file' is present.

Ideally, one or both of the above errors should be failing the build rather than letting errors pass silently.

Attachments (1)

Dockerfile (526 bytes) - added by anonymous 4 years ago.
Dockerfile for build environment

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by anonymous

Dockerfile for build environment

comment:1 Changed 4 years ago by nbd

  • Resolution set to fixed
  • Status changed from new to closed

Added a prereq check for 'file' in r40568
Please include the package in your apt-get command.

comment:2 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.