Modify

Opened 4 years ago

Last modified 4 years ago

#15371 reopened defect

Missing reset functionality (jffs2reset) in trunk

Reported by: anonymous Owned by: developers
Priority: high Milestone: Chaos Calmer 15.05
Component: base system Version: Trunk
Keywords: firstboot jffs2reset Cc:

Description

My new ar71xx/wr703n trunk build 40010 seems to be missing the reset functionality.
firstboot is currently just a short script leading to /sbin/jffs2reset

Attachments (0)

Change History (5)

comment:1 Changed 4 years ago by hnyman

Based on quick look, r39895 removed jffs2reset (both symlink and binary) from ubox, but did not re-introduce the same functionality in the new fstools package.

It looks to me that the functionality is possibly in jffs2.c being part of fs-state binary, but as no jffs2reset symlink is generated, jffs2reset command does not get recognized and passed to fs-state to be handled.

http://nbd.name/gitweb.cgi?p=fstools.git;a=blob;f=backend/jffs2.c;h=feb37d2913de3220d579018972c0cb1508f6881a;hb=d292ffc85f48dd9c8774a0860f50397dd2966e7a

comment:2 Changed 4 years ago by hnyman

has been fixed by r40018

comment:3 Changed 4 years ago by blogic

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 4 years ago by hnyman

  • Resolution fixed deleted
  • Status changed from closed to reopened

hmmmm.
I am reopening the bug. Although jffs2reset is again there since r40018, the actual reset functionality seems to be broken. r40018 forgot to pass the -y argument.

#15400 led me to test the situation, and yes, the current implementation calls the right script, but does not work, as it does not pass the confirmation "-y" to fs-state.
http://nbd.name/gitweb.cgi?p=fstools.git;a=blob;f=backend/jffs2.c;h=feb37d2913de3220d579018972c0cb1508f6881a;hb=d292ffc85f48dd9c8774a0860f50397dd2966e7a#l171

Reset button action gets logged ok, but no reset happens. (my script has immediate reset, no 5 sec waiting).

Mon Mar 31 21:41:05 2014 daemon.info dnsmasq-dhcp[1911]: DHCPACK(br-lan) xxxxxx HNHD57JG
Mon Mar 31 21:45:16 2014 user.notice root: reset pressed for 1 seconds
Mon Mar 31 21:45:57 2014 user.notice root: reset pressed for 0 seconds
Mon Mar 31 21:47:32 2014 authpriv.info dropbear[4559]: Child connection from xxxxx

Faulty script:

root@OpenWrt:~# which jffs2reset
/sbin/jffs2reset
root@OpenWrt:~# cat /sbin/jffs2reset
#!/bin/sh

fs-state overlay jffs2reset

https://dev.openwrt.org/browser/trunk/package/system/fstools/files/jffs2reset
/sbin/jffs2reset script that works ok and make my router to reset:

#!/bin/sh

fs-state overlay jffs2reset -y

comment:5 Changed 4 years ago by anonymous

I think this bug got fixed in commit r40383. But with commit r40415 jffs2reset got deleted again. Does somebody know why?

Add Comment

Modify Ticket

Action
as reopened .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.