Modify

Opened 4 years ago

Closed 4 years ago

#15070 closed defect (fixed)

Dropbear ignores Interface setting

Reported by: anonymous Owned by: developers
Priority: low Milestone: Chaos Calmer 15.05
Component: packages Version: Trunk
Keywords: Cc:

Description

The setting 'Interface' in /etc/config/dropbear is ignored and default used instead.

Attachments (0)

Change History (6)

comment:1 Changed 4 years ago by anonymous

I can't attach a patch, but her it is:

--- rom/etc/init.d/dropbear 2014-02-23 17:09:38.728235534 +0100
+++ overlay/etc/init.d/dropbear 2014-02-23 17:10:02.816236252 +0100
@@ -72,7 +72,7 @@

[ -n "${rsakeyfile}" ] && procd_append_param command -r "${rsakeyfile}"
[ -n "${dsskeyfile}" ] && procd_append_param command -d "${dsskeyfile}"
[ -n "${BannerFile}" ] && procd_append_param command -b "${BannerFile}"

  • [ -n "${interface}" ] && network_get_device interface "${interface}"

+ [ -n "${Interface}" ] && network_get_device interface "${Interface}"

append_ports "${interface}" "${Port}"
procd_close_instance

}

comment:2 Changed 4 years ago by hnyman

The error has apparently been introduced by r38787, which mixes Interface and interface. Validate section uses capital letter "Interface", while the actual option section uses small letter "interface".

https://dev.openwrt.org/browser/trunk/package/network/services/dropbear/files/dropbear.init#L40
https://dev.openwrt.org/browser/trunk/package/network/services/dropbear/files/dropbear.init#L75

comment:3 Changed 4 years ago by Catalin Patulea <cronos586@…>

Posted patch to openwrt-devel. We'll see if anyone actually bothers to commit..
http://patchwork.openwrt.org/patch/4932/

comment:4 Changed 4 years ago by anonymous

bump

comment:5 Changed 4 years ago by Catalin Patulea <cronos586@…>

comment:6 Changed 4 years ago by nbd

  • Resolution set to fixed
  • Status changed from new to closed

fixed in r40298

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.