Modify

Opened 11 years ago

Closed 6 years ago

Last modified 4 years ago

#1458 closed defect (wontfix)

configure kmod params in config files

Reported by: ffrrrr at gmail Owned by: developers
Priority: normal Milestone: Features Paradise
Component: base system Version: Kamikaze trunk
Keywords: Cc:

Description

Use /bin/uci to get kmod parameters as options from config files.

Parameters must be declared with the name of the module in AUTOLOAD with :

\"<kmod-name> <uci-package> <uci-config> <option-name> [<option-name> ...]\"

to be available as option in the corresponding config section.

The patch contains ath_pci parameters declared in madwifi makefile.

Attachments (2)

call-kmod-params-from-config.patch (1.9 KB) - added by ffrrrr at gmail 11 years ago.
patch to get kmod parameters as options in config files
call_kmod_params_from_config.patch (531 bytes) - added by ffrrrr at gmail 10 years ago.
less intrusive patch

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by ffrrrr at gmail

patch to get kmod parameters as options in config files

Changed 10 years ago by ffrrrr at gmail

less intrusive patch

comment:1 Changed 10 years ago by ffrrrr at gmail

This second patch allows to configure kernel modules paramters from uci config files.

For a kernel module 'mod' which can be loaded with 'param1' and 'param2' like :

insmod mod param1=val1 param2=value2

A config file '/etc/config/mod' can be created with the following content :

$ cat /etc/config/mod
config kernel-module options
   option param1 val1
   option param2 val2

For example, the ath_pci kernel module can be configured in /etc/config/ath_pci with :

$ cat /etc/config/ath_pci
config kernel-module options
   option countrycode 250
   option outdoor 1

comment:2 Changed 8 years ago by thepeople

  • Milestone set to Kamikaze Features Paradize
  • Version set to Kamikaze trunk

comment:3 Changed 7 years ago by Ted Hess <thess@…>

Any chance of getting this merged into the trunk? I've been using this patch for over a year now with no bad side-effects. Very useful for custom/extended driver work.

comment:4 Changed 6 years ago by nbd

  • Resolution set to wontfix
  • Status changed from new to closed

i don't think module parameters should be configured through uci. sane drivers should not need to have things configured via module parameters, and even madwifi does not need this.

comment:5 Changed 6 years ago by thess

Too bad -- bttv.ko is not a sane module :(

comment:6 Changed 4 years ago by marcelo@…

There's an easy workaround.
Edit /etc/modules.d/XXXXX
add parameters after module name
Tested with 12.09 final

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.